From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754906AbdKNMuF (ORCPT ); Tue, 14 Nov 2017 07:50:05 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:46216 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754791AbdKNMtu (ORCPT ); Tue, 14 Nov 2017 07:49:50 -0500 Date: Tue, 14 Nov 2017 12:48:07 +0000 From: Roman Gushchin To: Mike Kravetz CC: Johannes Weiner , Dave Hansen , , Andrew Morton , Michal Hocko , "Aneesh Kumar K.V" , Andrea Arcangeli , , Subject: Re: [PATCH] mm: show stats for non-default hugepage sizes in /proc/meminfo Message-ID: <20171114124800.GA5321@castle> References: <20171113160302.14409-1-guro@fb.com> <8aa63aee-cbbb-7516-30cf-15fcf925060b@intel.com> <20171113181105.GA27034@castle> <2579a26d-81d1-732e-ef57-33bb4c293cd6@oracle.com> <20171113184454.GA18531@castle> <20171113191056.GA28749@cmpxchg.org> <0842738c-1c6f-9a29-b9a6-21e5af898c31@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0842738c-1c6f-9a29-b9a6-21e5af898c31@oracle.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c092:200::1:c60] X-ClientProxiedBy: AM4P190CA0007.EURP190.PROD.OUTLOOK.COM (2603:10a6:200:56::17) To SN2PR15MB1087.namprd15.prod.outlook.com (2603:10b6:804:22::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50ec2e86-446e-4c5c-a747-08d52b5dfc82 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:SN2PR15MB1087; X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1087;3:u35JfRiE3VNOPHpycjNYL5rgSicT2D+o+FYQtdGZzVyw8VwWAINpJdBNunAmG7NgCvSf7XjRI5DhLfp5vZQhAdhBVvwMH+VXJ9+z8Uva+iqgGeI9x/fALmGCZv69nRyUytz0UrZnvltygxmPGtXcxfnZOTKAlssEDALh/UASaBcwGfN+1jwETs4sucRrtlI6RmCWAMWGQZz3z2aMxE1eVF9XtWLWrsnr1RLBMWoHWiV7tddULyTLZb1Cf16Flw3j;25:hX0GXvxB/RMD39d2QyfAAy7c8hfzC8WenTOCJYUUpw7LxRmwummI3p4wq5Bd12lwDgw2UKM55uMqJACQQReA3euVMXFTJCG8/5+MpRfvxKD3QZI0WLoyTKiReBRahznlBKfxWnAKUlU8QmWCVutr1SQEhLNxvR3+ydIC1fZtjZgh/1+TmPYlzd7HrsIPKh+z9jKhznb9k6bKEbHf64fthdikX6XxXHuL607acjC+ex2zdHzF/YNXa9ogpZ7lvEGYhs+bz8XqJFvOlDSRzovqxPiCJXSG20AWTVbffGZcQOpNd9Ix+qZDWR/RbOlC/4cPss/kbD4t2fCO720AfuqJjPPN9cXGeFyLF+cPpcvTKYk=;31:6NHZJueURiRzj7L2p/QBYN3Zafn/ypong2+cxrP0nS1MnyDq8tSw0W//tmyAtdA3rQnYSisSalB8fW2NR6Dfbk1b8/eapKu5f/hbOe3JDCtaI/J2Xt0ZQeIo3SAqb8jMGxKQg3GOZ4fMLqeAUzyyAf4s3Yf1JEYyG5/ybpiBvk1Prf92bkJZ+4tDWj4OfE+wFyP4hU7GsrFDKZcwLYD8me/dp2McLCbf4gy3oMoTtro= X-MS-TrafficTypeDiagnostic: SN2PR15MB1087: X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1087;20:Q0ky6ZR0/vGlVHzntWAZevwBayDf3+0Q3mpqMSBsBI47sPBvFi01rFv7mKAOyI4Br9CNXjxbjDXF9rgXr2MJArLIpwOzedUtpodWDL3sc6UbQoLW5t+zvnPmO4jPBNrlnkyYhxA/EMRwEqPgvuAlsW210H5TcHphy+aFQFXfH5rdmmLeg6Li4RJsMc+Dzm+dO6FEWYTpmxUd7XiHZQGTJhiW3QvCp1xYCsy+xHSzNwFVp08wqvXyL9ikwOYJU2BQf+vhD+ERd4A8lgBMPfuVl49+3wkTw9z3398ldxHlDbn31sukQGLfWIHE5f5csOI5oQ51uYklGqQdaOSSAHdbQCjdQehwXwkzO9bdrm2fu83OvRHY1JJRV+4XO6Dh9VvCx9WWgoN0bpFcuNpFPULiYGaQKA9qA/2kAbKU3FDz55VlsDxWo9KKcu4OXiXHpWdTTNIkfcw0ZYph4CeG4d3WwEAttlaeYrLIeP9LZiKiQIXAs85v1Fxwvo2LGLs5vU66;4:PS+Iy7rqzUhbgdz4gRClP1uFi+OSxBOjLxgTNbu4XgVQVYWg/6RnbRTC5DREQ4Eheqyx7jCNq93uqLmM+BVr38xK7XxPI/xWHftVTI89Ew6L232tXLQBAh4KGJl2ZIIBKHLgbyna4Zg+h/9tcPqbAVh5nPiu60L/AyMSyHAzLaTfnUyNOyJV/vZon6mc4Y9Jxi8fHtzW4XogjSYuyAPH1sGIOPBPiEorG6lUaX+xwj9x5qWbhKihqrjpDA9Vwb16GxOR30zRpDLj2u0L2eRiTg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231022)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123562025)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN2PR15MB1087;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN2PR15MB1087; X-Forefront-PRVS: 04916EA04C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(189002)(199003)(24454002)(2950100002)(68736007)(33716001)(81166006)(8676002)(5660300001)(33656002)(6666003)(6916009)(305945005)(76176999)(81156014)(229853002)(6116002)(478600001)(101416001)(54356999)(2906002)(25786009)(1076002)(47776003)(23726003)(50986999)(7736002)(8936002)(83506002)(86362001)(97736004)(9686003)(55016002)(53936002)(105586002)(106356001)(58126008)(189998001)(53546010)(6246003)(6496005)(4326008)(54906003)(93886005)(316002)(16586007)(50466002)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN2PR15MB1087;H:castle;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR15MB1087;23:264KT0eTQpxhTCjKTEUtBqYvZc7fB9VkWqgISHr0h?= =?us-ascii?Q?dqN3vHBwtlVYWzkC/H6ny9/nzSwUS9lTEEradKL6wdHe3NMpBJijP3RVVXAj?= =?us-ascii?Q?/EcGrp8JJNg03f4ToKis/MpYsdMOUJJNMrFJvJ1hmV/LfuKI2p4zRiYnnQIl?= =?us-ascii?Q?q6EwySpW2hi2HrhibrkaMuoZW2oxfyHWNdAfij3iFgkHKq2BIvwGcZIKSdpE?= =?us-ascii?Q?CB3K51x+oI4NTY7seFk66vQJTEuDWyr/JZxiIuJ9uk3KO77Pg5v0SvNfYsY7?= =?us-ascii?Q?wvVG78oHTq+gDP38M8Z9gr0DQaIx5HIEvkzWb04al+6Z8ZB7ZbCR2tnKjeBY?= =?us-ascii?Q?ntNIKnTyZF1c6luEKZJh7WsEMsGwkX/W7YAr4SjKbt4q+zNXLzdlUDSZc6af?= =?us-ascii?Q?0+maaBvB4P4os4ndEPowtBjn3uujJ++nYBwT3wVDA0p+owB8PbzJBTy5p/CA?= =?us-ascii?Q?cVkOQXCQOQnkBaZw7wXO9LWTfbQvcoxBRusI6EPUsGBAU0oVrAUzf9Za3HOX?= =?us-ascii?Q?eL9ueahk9USVV7XYPrlg+CjwJmY8n5R6yIl4F8JwK7UVUQZUlEnDhVyGkQfJ?= =?us-ascii?Q?VtEGbGGlK+yXspOHFeqyzCXe/CEHFsTGY5b5/GbFOSjR64TSXop/QsFKxZhs?= =?us-ascii?Q?jkBv1IB8dBEfFDhX/qoP9S47DmkJFqyOtbdoOVK1nTYfe6kuCnGb5J7aCRGk?= =?us-ascii?Q?IEaa8EhFycmbMYBV8WcmvB+XzPcKea5Xxeo4kycHr/LiMFxPt5L7rnf+FjUA?= =?us-ascii?Q?xbEAYOwN445Mknz/DAj4lgDaSMubmXOXqV87HtxEmnsGOEXqCwKVKJfbZSPB?= =?us-ascii?Q?XA//ZBevshfrlj3vIRKsIMfKh3X8lKPKZ2AqZnS1GaIt131Sbn6rhi4ndLq0?= =?us-ascii?Q?OpHFjQBmkjsx4oYt4agKjl5OSBa7sBS+eO5xS9gaupWAMixr3YWybDIjgy+n?= =?us-ascii?Q?BRw0MdnUdi2jkPL3HEaZs1UHhJ9osnp7lXJVPXvk19kpMZ5ShuWi0jfWieVx?= =?us-ascii?Q?k0wR1cf4O2Yy60T6wLjQRc/0ecRi+NORuCIQvDbUgHzr7lIVLWlfDayEIwh3?= =?us-ascii?Q?uWL4QbquXCqyiZPL28QNthDGWf3MWxTrggDA0wJqI8IIebGoHCOQq7T183uW?= =?us-ascii?Q?JsRy7sAGaHFS1y10drW29nalA1q7EXBmGnTCcCYKiNZEMdzRS1eC2EMwPKIK?= =?us-ascii?Q?exZG6oVXwflv+BU1cPh2XEFDMWIaUptNQZE?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1087;6:xcDdKpMtlUTYVEPMNz4+xJbMI+lPULnCzK1BObB3fPkulEKtTiywiX4RYzIWUf9m7+wHiITFJ48UBvony/86e+z5KrrWJ0S4gSwmz88CVJ6GZFLhfxMnHB1y6LPRbW/ywODpqm33//LvBbha+xsDLt6MTW50LjCoNxNL3UPEzbD+0FXWBXT56Go/0spWzL5S0Aio0ZHm95y5f2RbGRgatgwCYR8uM95rL1k00lJLuPfH9BB4IEnSEQ/z8EDw0Un6y8be7yCmoBFjDu/bfzt5Fh5ui5VCgoyiYPOLBF4T0lkmqaW/NuUebNnu//GTnpkn+0YM/liTsFug+u6bmlpqshTssjywsQ0oaIUXQqjdyMM=;5:oi+T+WnZGY/ao43H3y2TxbKjeHX6Ls9TbqQPzsc8gU3djGVyd7a/d67bs4y+Sh9OdokfU4eFa2Zm7qxABa6tXRZbm9rkNBeO98+GutWIBS1wymS+lKxGeFaDtWPNquKYP0jd0hVvVVgK1CPGSX7Opo0YzawapssiUYrrPt1B+pk=;24:8TKRZFCr8lbpEyIJXa214qF5D9LvUHJE3O/vxjGKkgGX+zvyNw4eKZjnmHwD6i3pKZ1ZaPD+FQESfdTFui4u2xT2UjWlkrpLE3wEsXC3hTU=;7:1N8nCcCe41VTShK6fw2qIC1Z/OwmD2cz712f+YNa51GMdXKeYNdTpbd9yqDkOI87eN/2naQcmTMrzYHu/Fojc138fqIOaF8QwpWRTw5WC42d6YsflJgT94n8X7uhTiYylQaDpfC0ep8L+/JcHOdJWzbntQPTpyuXsDZGv+hyS8W5OBcmOmSHWjXqW/bYqPfKtA3Sf1qSTtpJUJdnp03TaK14Jwwap9ZhiDmSCm3+j6gEF2+y7WfNfqDK/IAsP+yC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1087;20:wuBsmvxyRMdy8ZVqiCyGi4X8CvXpC3v91PblXiVIkD+nkt/rUmTCyNqxRbqAA0+yi3ZqpOuCihJT9ZIDjJ2BG9Tf6mN2G35H3Wu64oy7KedPYL0DvQDX8darT/mAfZciC0rqch+/CKyQYlwBNemOH854heHPaX3tUQ57isHiOJE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2017 12:48:19.5072 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50ec2e86-446e-4c5c-a747-08d52b5dfc82 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR15MB1087 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-14_05:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 11:25:21AM -0800, Mike Kravetz wrote: > On 11/13/2017 11:10 AM, Johannes Weiner wrote: > > On Mon, Nov 13, 2017 at 06:45:01PM +0000, Roman Gushchin wrote: > >> Or, at least, some total counter, e.g. how much memory is consumed > >> by hugetlb pages? > > > > I'm not a big fan of the verbose breakdown for every huge page size. > > As others have pointed out such detail exists elswhere. > > > > But I do think we should have a summary counter for memory consumed by > > hugetlb that lets you know how much is missing from MemTotal. This can > > be large parts of overall memory, and right now /proc/meminfo will > > give the impression we are leaking those pages. > > > > Maybe a simple summary counter for everything set aside by the hugetlb > > subsystem - default and non-default page sizes, whether they're used > > or only reserved etc.? > > > > Hugetlb 12345 kB > > I would prefer this approach. The 'trick' is coming up with a name or > description that is not confusing. Unfortunately, we have to leave the > existing entries. So, this new entry will be greater than or equal to > HugePages_Total. :( I guess Hugetlb is as good of a name as any? Yes, I like this approach too, and Hugetlb (in kB) sounds reasonable. I'll post a new patch soon. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id C032D6B0033 for ; Tue, 14 Nov 2017 07:48:36 -0500 (EST) Received: by mail-pg0-f69.google.com with SMTP id r12so9145677pgu.9 for ; Tue, 14 Nov 2017 04:48:36 -0800 (PST) Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com. [67.231.153.30]) by mx.google.com with ESMTPS id b21si15366895pfe.291.2017.11.14.04.48.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Nov 2017 04:48:35 -0800 (PST) Date: Tue, 14 Nov 2017 12:48:07 +0000 From: Roman Gushchin Subject: Re: [PATCH] mm: show stats for non-default hugepage sizes in /proc/meminfo Message-ID: <20171114124800.GA5321@castle> References: <20171113160302.14409-1-guro@fb.com> <8aa63aee-cbbb-7516-30cf-15fcf925060b@intel.com> <20171113181105.GA27034@castle> <2579a26d-81d1-732e-ef57-33bb4c293cd6@oracle.com> <20171113184454.GA18531@castle> <20171113191056.GA28749@cmpxchg.org> <0842738c-1c6f-9a29-b9a6-21e5af898c31@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0842738c-1c6f-9a29-b9a6-21e5af898c31@oracle.com> Sender: owner-linux-mm@kvack.org List-ID: To: Mike Kravetz Cc: Johannes Weiner , Dave Hansen , linux-mm@kvack.org, Andrew Morton , Michal Hocko , "Aneesh Kumar K.V" , Andrea Arcangeli , kernel-team@fb.com, linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 11:25:21AM -0800, Mike Kravetz wrote: > On 11/13/2017 11:10 AM, Johannes Weiner wrote: > > On Mon, Nov 13, 2017 at 06:45:01PM +0000, Roman Gushchin wrote: > >> Or, at least, some total counter, e.g. how much memory is consumed > >> by hugetlb pages? > > > > I'm not a big fan of the verbose breakdown for every huge page size. > > As others have pointed out such detail exists elswhere. > > > > But I do think we should have a summary counter for memory consumed by > > hugetlb that lets you know how much is missing from MemTotal. This can > > be large parts of overall memory, and right now /proc/meminfo will > > give the impression we are leaking those pages. > > > > Maybe a simple summary counter for everything set aside by the hugetlb > > subsystem - default and non-default page sizes, whether they're used > > or only reserved etc.? > > > > Hugetlb 12345 kB > > I would prefer this approach. The 'trick' is coming up with a name or > description that is not confusing. Unfortunately, we have to leave the > existing entries. So, this new entry will be greater than or equal to > HugePages_Total. :( I guess Hugetlb is as good of a name as any? Yes, I like this approach too, and Hugetlb (in kB) sounds reasonable. I'll post a new patch soon. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org