Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

From: Dave Chinner <david@fromorbit.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Yu Chen <yu.c.chen@intel.com>, Michal Hocko <mhocko@suse.com>,
	Hendrik Woltersdorf <hendrikw@arcor.de>,
	Dave Chinner <dchinner@redhat.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	Jiri Kosina <jkosina@suse.cz>, Len Brown <len.brown@intel.com>,
	Rui Zhang <rui.zhang@intel.com>, Yu Chen <yu.chen.surf@gmail.com>,
	linux-xfs@vger.kernel.org,
	Linux-pm mailing list <linux-pm@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	Thorsten Leemhuis <linux@leemhuis.info>,
	oleg.b.antonyan@gmail.com, Oliver Neukum <oneukum@suse.com>
Subject: Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild
Date: Wed, 15 Nov 2017 08:25:38 +1100	[thread overview]
Message-ID: <20171114212538.GC4094@dastard> (raw)
In-Reply-To: <20171114201915.GI729@wotan.suse.de>

On Tue, Nov 14, 2017 at 09:19:15PM +0100, Luis R. Rodriguez wrote:
> This is another way to say suspend has been busted on XFS for a very long time,
> but I would not blame XFS -- this is a kernel issue to get proper filesystem
> suspend working right, and the way we currently deal with kthreads is just
> a sloppy goo mess which has created this situation.

Yes, and I've been telling people that suspend on journalling
filesystems has been broken for a long time (i.e since I first
realised the scope of the problem back in 2005). However, only XFS
triggers those conditions regularly because it is the most
asynchronous of the "freezable" journalling filesytems and has the
most reliance on co-ordination of kernel threads and workqueues to
function correctly.

IOWs, suspend of filesystems has been broken forever, and we've been
slapping bandaids on it in XFS forever. Now we've got to a
catch-22 situation that bandaids can't fix. We need structural
fixes, like I said we needed to do more than 10 years ago.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com