From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
will.deacon@arm.com, Bob Liu <liubo95@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Ingo Molnar <mingo@kernel.org>, Roman Gushchin <guro@fb.com>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] arch, mm: introduce arch_tlb_gather_mmu_lazy (was: Re: [RESEND PATCH] mm, oom_reaper: gather each vma to prevent) leaking TLB entry
Date: Wed, 15 Nov 2017 09:12:36 +0900 [thread overview]
Message-ID: <20171115001236.GA23810@bbox> (raw)
In-Reply-To: <20171114072100.uwkbakxzdkroga7r@dhcp22.suse.cz>
On Tue, Nov 14, 2017 at 08:21:00AM +0100, Michal Hocko wrote:
> On Tue 14-11-17 10:45:49, Minchan Kim wrote:
> [...]
> > Anyway, I think Wang Nan's patch is already broken.
> > http://lkml.kernel.org/r/%3C20171107095453.179940-1-wangnan0@huawei.com%3E
> >
> > Because unmap_page_range(ie, zap_pte_range) can flush TLB forcefully
> > and free pages. However, the architecture code for TLB flush cannot
> > flush at all by wrong fullmm so other threads can write freed-page.
>
> I am not sure I understand what you mean. How is that any different from
> any other explicit partial madvise call?
Argh, I misread his code. Sorry for that.
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
will.deacon@arm.com, Bob Liu <liubo95@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Ingo Molnar <mingo@kernel.org>, Roman Gushchin <guro@fb.com>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] arch, mm: introduce arch_tlb_gather_mmu_lazy (was: Re: [RESEND PATCH] mm, oom_reaper: gather each vma to prevent) leaking TLB entry
Date: Wed, 15 Nov 2017 09:12:36 +0900 [thread overview]
Message-ID: <20171115001236.GA23810@bbox> (raw)
In-Reply-To: <20171114072100.uwkbakxzdkroga7r@dhcp22.suse.cz>
On Tue, Nov 14, 2017 at 08:21:00AM +0100, Michal Hocko wrote:
> On Tue 14-11-17 10:45:49, Minchan Kim wrote:
> [...]
> > Anyway, I think Wang Nan's patch is already broken.
> > http://lkml.kernel.org/r/%3C20171107095453.179940-1-wangnan0@huawei.com%3E
> >
> > Because unmap_page_range(ie, zap_pte_range) can flush TLB forcefully
> > and free pages. However, the architecture code for TLB flush cannot
> > flush at all by wrong fullmm so other threads can write freed-page.
>
> I am not sure I understand what you mean. How is that any different from
> any other explicit partial madvise call?
Argh, I misread his code. Sorry for that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-15 0:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 9:54 [RESEND PATCH] mm, oom_reaper: gather each vma to prevent leaking TLB entry Wang Nan
2017-11-07 9:54 ` Wang Nan
2017-11-07 10:09 ` Michal Hocko
2017-11-07 10:09 ` Michal Hocko
2017-11-10 0:19 ` Minchan Kim
2017-11-10 0:19 ` Minchan Kim
2017-11-10 10:15 ` Michal Hocko
2017-11-10 10:15 ` Michal Hocko
2017-11-10 12:26 ` [PATCH] arch, mm: introduce arch_tlb_gather_mmu_lazy (was: Re: [RESEND PATCH] mm, oom_reaper: gather each vma to prevent) " Michal Hocko
2017-11-10 12:26 ` Michal Hocko
2017-11-13 0:28 ` Minchan Kim
2017-11-13 0:28 ` Minchan Kim
2017-11-13 9:51 ` Michal Hocko
2017-11-13 9:51 ` Michal Hocko
2017-11-14 1:45 ` Minchan Kim
2017-11-14 1:45 ` Minchan Kim
2017-11-14 7:21 ` Michal Hocko
2017-11-14 7:21 ` Michal Hocko
2017-11-15 0:12 ` Minchan Kim [this message]
2017-11-15 0:12 ` Minchan Kim
2017-11-15 8:14 ` Michal Hocko
2017-11-15 8:14 ` Michal Hocko
2017-11-16 0:44 ` Minchan Kim
2017-11-16 0:44 ` Minchan Kim
2017-11-16 9:19 ` Michal Hocko
2017-11-16 9:19 ` Michal Hocko
2017-11-15 17:33 ` Will Deacon
2017-11-15 17:33 ` Will Deacon
2017-11-16 9:20 ` Michal Hocko
2017-11-16 9:20 ` Michal Hocko
2017-11-20 14:24 ` Will Deacon
2017-11-20 14:24 ` Will Deacon
2017-11-20 16:04 ` [PATCH] arch, mm: introduce arch_tlb_gather_mmu_lazy Michal Hocko
2017-11-20 16:04 ` Michal Hocko
2017-11-22 19:30 ` Will Deacon
2017-11-22 19:30 ` Will Deacon
2017-11-23 6:18 ` Minchan Kim
2017-11-23 6:18 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115001236.GA23810@bbox \
--to=minchan@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liubo95@huawei.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=rientjes@google.com \
--cc=wangnan0@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.