From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756314AbdKOAMq (ORCPT ); Tue, 14 Nov 2017 19:12:46 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:43624 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbdKOAMi (ORCPT ); Tue, 14 Nov 2017 19:12:38 -0500 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.220.163 X-Original-MAILFROM: minchan@kernel.org Date: Wed, 15 Nov 2017 09:12:36 +0900 From: Minchan Kim To: Michal Hocko Cc: Wang Nan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, will.deacon@arm.com, Bob Liu , Andrew Morton , David Rientjes , Ingo Molnar , Roman Gushchin , Konstantin Khlebnikov , Andrea Arcangeli Subject: Re: [PATCH] arch, mm: introduce arch_tlb_gather_mmu_lazy (was: Re: [RESEND PATCH] mm, oom_reaper: gather each vma to prevent) leaking TLB entry Message-ID: <20171115001236.GA23810@bbox> References: <20171107095453.179940-1-wangnan0@huawei.com> <20171110001933.GA12421@bbox> <20171110101529.op6yaxtdke2p4bsh@dhcp22.suse.cz> <20171110122635.q26xdxytgdfjy5q3@dhcp22.suse.cz> <20171113002833.GA18301@bbox> <20171113095107.24hstywywxk7nx7e@dhcp22.suse.cz> <20171114014549.GA1995@bgram> <20171114072100.uwkbakxzdkroga7r@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171114072100.uwkbakxzdkroga7r@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 08:21:00AM +0100, Michal Hocko wrote: > On Tue 14-11-17 10:45:49, Minchan Kim wrote: > [...] > > Anyway, I think Wang Nan's patch is already broken. > > http://lkml.kernel.org/r/%3C20171107095453.179940-1-wangnan0@huawei.com%3E > > > > Because unmap_page_range(ie, zap_pte_range) can flush TLB forcefully > > and free pages. However, the architecture code for TLB flush cannot > > flush at all by wrong fullmm so other threads can write freed-page. > > I am not sure I understand what you mean. How is that any different from > any other explicit partial madvise call? Argh, I misread his code. Sorry for that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id 430F46B0033 for ; Tue, 14 Nov 2017 19:12:40 -0500 (EST) Received: by mail-pf0-f199.google.com with SMTP id 82so8509786pfp.5 for ; Tue, 14 Nov 2017 16:12:40 -0800 (PST) Received: from lgeamrelo13.lge.com (LGEAMRELO13.lge.com. [156.147.23.53]) by mx.google.com with ESMTP id f9si320035pfc.10.2017.11.14.16.12.37 for ; Tue, 14 Nov 2017 16:12:38 -0800 (PST) Date: Wed, 15 Nov 2017 09:12:36 +0900 From: Minchan Kim Subject: Re: [PATCH] arch, mm: introduce arch_tlb_gather_mmu_lazy (was: Re: [RESEND PATCH] mm, oom_reaper: gather each vma to prevent) leaking TLB entry Message-ID: <20171115001236.GA23810@bbox> References: <20171107095453.179940-1-wangnan0@huawei.com> <20171110001933.GA12421@bbox> <20171110101529.op6yaxtdke2p4bsh@dhcp22.suse.cz> <20171110122635.q26xdxytgdfjy5q3@dhcp22.suse.cz> <20171113002833.GA18301@bbox> <20171113095107.24hstywywxk7nx7e@dhcp22.suse.cz> <20171114014549.GA1995@bgram> <20171114072100.uwkbakxzdkroga7r@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171114072100.uwkbakxzdkroga7r@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Wang Nan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, will.deacon@arm.com, Bob Liu , Andrew Morton , David Rientjes , Ingo Molnar , Roman Gushchin , Konstantin Khlebnikov , Andrea Arcangeli On Tue, Nov 14, 2017 at 08:21:00AM +0100, Michal Hocko wrote: > On Tue 14-11-17 10:45:49, Minchan Kim wrote: > [...] > > Anyway, I think Wang Nan's patch is already broken. > > http://lkml.kernel.org/r/%3C20171107095453.179940-1-wangnan0@huawei.com%3E > > > > Because unmap_page_range(ie, zap_pte_range) can flush TLB forcefully > > and free pages. However, the architecture code for TLB flush cannot > > flush at all by wrong fullmm so other threads can write freed-page. > > I am not sure I understand what you mean. How is that any different from > any other explicit partial madvise call? Argh, I misread his code. Sorry for that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org