From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932440AbdKOLuc (ORCPT ); Wed, 15 Nov 2017 06:50:32 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:60651 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932369AbdKOLuK (ORCPT ); Wed, 15 Nov 2017 06:50:10 -0500 Date: Wed, 15 Nov 2017 12:50:06 +0100 From: Peter Zijlstra To: Jarkko Sakkinen Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH v5 08/11] intel_sgx: in-kernel launch enclave Message-ID: <20171115115006.p2wkvfuojwgg26br@hirez.programming.kicks-ass.net> References: <20171113194528.28557-1-jarkko.sakkinen@linux.intel.com> <20171113194528.28557-9-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171113194528.28557-9-jarkko.sakkinen@linux.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 09:45:25PM +0200, Jarkko Sakkinen wrote: > TinyCrypt (https://github.com/01org/tinycrypt) is used as AES > implementation, which is not timing resistant. Eventually this needs to > be replaced with AES-NI based implementation that could be either > - re-use existing AES-NI code in the kernel This. That is an absolute must. We're not going to merge custom AES implementations.