From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965014AbdKPVEO (ORCPT ); Thu, 16 Nov 2017 16:04:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60186 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935206AbdKPVEI (ORCPT ); Thu, 16 Nov 2017 16:04:08 -0500 Date: Thu, 16 Nov 2017 15:04:05 -0600 From: Josh Poimboeuf To: Juergen Gross Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Linus Torvalds , Sasha Levin , live-patching@vger.kernel.org, Jiri Slaby , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , Mike Galbraith , Chris Wright , Alok Kataria , Rusty Russell , virtualization@lists.linux-foundation.org, Boris Ostrovsky , xen-devel@lists.xenproject.org, Thomas Gleixner , Borislav Petkov Subject: Re: [PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros Message-ID: <20171116210405.xzagz5o5sphivldt@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 16 Nov 2017 21:04:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 25, 2017 at 11:46:18AM +0200, Juergen Gross wrote: > On 04/10/17 17:58, Josh Poimboeuf wrote: > > Convert the hard-coded native patch assembly code strings to macros to > > facilitate sharing common code between 32-bit and 64-bit. > > > > These macros will also be used by a future patch which requires the GCC > > extended asm syntax of two '%' characters instead of one when specifying > > a register name. > > > > Signed-off-by: Josh Poimboeuf > > Reviewed-by: Juergen Gross > > Mind adding another patch to merge the now nearly identical > paravirt_patch_32.c and paravirt_patch_64.c either into paravirt.c > or paravirt_patch.c? This would require only very few #ifdef. Good idea, will do. -- Josh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Poimboeuf Subject: Re: [PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros Date: Thu, 16 Nov 2017 15:04:05 -0600 Message-ID: <20171116210405.xzagz5o5sphivldt@treble> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Juergen Gross Cc: Boris Ostrovsky , Rusty Russell , Mike Galbraith , xen-devel@lists.xenproject.org, Peter Zijlstra , Jiri Slaby , x86@kernel.org, linux-kernel@vger.kernel.org, Sasha Levin , Chris Wright , Thomas Gleixner , Andy Lutomirski , "H. Peter Anvin" , Borislav Petkov , live-patching@vger.kernel.org, Alok Kataria , virtualization@lists.linux-foundation.org, Linus Torvalds , Ingo Molnar List-Id: virtualization@lists.linuxfoundation.org On Wed, Oct 25, 2017 at 11:46:18AM +0200, Juergen Gross wrote: > On 04/10/17 17:58, Josh Poimboeuf wrote: > > Convert the hard-coded native patch assembly code strings to macros to > > facilitate sharing common code between 32-bit and 64-bit. > > > > These macros will also be used by a future patch which requires the GCC > > extended asm syntax of two '%' characters instead of one when specifying > > a register name. > > > > Signed-off-by: Josh Poimboeuf > > Reviewed-by: Juergen Gross > > Mind adding another patch to merge the now nearly identical > paravirt_patch_32.c and paravirt_patch_64.c either into paravirt.c > or paravirt_patch.c? This would require only very few #ifdef. Good idea, will do. -- Josh