From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934655AbdKPVhP (ORCPT ); Thu, 16 Nov 2017 16:37:15 -0500 Received: from mail-pg0-f43.google.com ([74.125.83.43]:34482 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758584AbdKPVhG (ORCPT ); Thu, 16 Nov 2017 16:37:06 -0500 X-Google-Smtp-Source: AGs4zMbw9Zj6zRW85Izo6zvrldbH86Sp38yO+0J+Vj8JcCG+cnhyja7okYuguWvDJ3rZZjnlgymo2g== Date: Thu, 16 Nov 2017 13:37:03 -0800 From: Sami Tolvanen To: Ard Biesheuvel Cc: Will Deacon , Mark Rutland , Andi Kleen , Kees Cook , linux-kbuild@vger.kernel.org, Nick Desaulniers , "linux-kernel@vger.kernel.org" , Greg Hackmann , Masahiro Yamada , Michal Marek , Yury Norov , Alex Matveev , Matthias Kaehlcke , "linux-arm-kernel@lists.infradead.org" , Maxim Kuvyrkov Subject: Re: [PATCH v2 08/18] arm64: don't disable ADR_PREL_PG_HI21* with ARM64_ERRATUM_843419 Message-ID: <20171116213702.GA10616@samitolvanen.mtv.corp.google.com> References: <20171115213428.22559-1-samitolvanen@google.com> <20171115213428.22559-9-samitolvanen@google.com> <20171116114406.GB9361@arm.com> <20171116163132.GC94341@samitolvanen.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 04:34:03PM +0000, Ard Biesheuvel wrote: > You still have not explained to us how GOLD avoids the erratum. Sorry, I didn't realize you were asking that. If gold spots erratum sequences, looks like it creates stubs to break them up: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gold/aarch64.cc#l8396 It also attempts to optimize the code by replacing adrps in these sequences with adr where possible, but otherwise doesn't appear to touch them: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gold/aarch64.cc#l2053 Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f53.google.com ([74.125.83.53]:40402 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbdKPVhG (ORCPT ); Thu, 16 Nov 2017 16:37:06 -0500 Received: by mail-pg0-f53.google.com with SMTP id u3so315821pgn.7 for ; Thu, 16 Nov 2017 13:37:06 -0800 (PST) Date: Thu, 16 Nov 2017 13:37:03 -0800 From: Sami Tolvanen Subject: Re: [PATCH v2 08/18] arm64: don't disable ADR_PREL_PG_HI21* with ARM64_ERRATUM_843419 Message-ID: <20171116213702.GA10616@samitolvanen.mtv.corp.google.com> References: <20171115213428.22559-1-samitolvanen@google.com> <20171115213428.22559-9-samitolvanen@google.com> <20171116114406.GB9361@arm.com> <20171116163132.GC94341@samitolvanen.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Ard Biesheuvel Cc: Will Deacon , Mark Rutland , Andi Kleen , Kees Cook , linux-kbuild@vger.kernel.org, Nick Desaulniers , "linux-kernel@vger.kernel.org" , Greg Hackmann , Masahiro Yamada , Michal Marek , Yury Norov , Alex Matveev , Matthias Kaehlcke , "linux-arm-kernel@lists.infradead.org" , Maxim Kuvyrkov On Thu, Nov 16, 2017 at 04:34:03PM +0000, Ard Biesheuvel wrote: > You still have not explained to us how GOLD avoids the erratum. Sorry, I didn't realize you were asking that. If gold spots erratum sequences, looks like it creates stubs to break them up: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gold/aarch64.cc#l8396 It also attempts to optimize the code by replacing adrps in these sequences with adr where possible, but otherwise doesn't appear to touch them: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gold/aarch64.cc#l2053 Sami From mboxrd@z Thu Jan 1 00:00:00 1970 From: samitolvanen@google.com (Sami Tolvanen) Date: Thu, 16 Nov 2017 13:37:03 -0800 Subject: [PATCH v2 08/18] arm64: don't disable ADR_PREL_PG_HI21* with ARM64_ERRATUM_843419 In-Reply-To: References: <20171115213428.22559-1-samitolvanen@google.com> <20171115213428.22559-9-samitolvanen@google.com> <20171116114406.GB9361@arm.com> <20171116163132.GC94341@samitolvanen.mtv.corp.google.com> Message-ID: <20171116213702.GA10616@samitolvanen.mtv.corp.google.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Nov 16, 2017 at 04:34:03PM +0000, Ard Biesheuvel wrote: > You still have not explained to us how GOLD avoids the erratum. Sorry, I didn't realize you were asking that. If gold spots erratum sequences, looks like it creates stubs to break them up: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gold/aarch64.cc#l8396 It also attempts to optimize the code by replacing adrps in these sequences with adr where possible, but otherwise doesn't appear to touch them: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gold/aarch64.cc#l2053 Sami