From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752724AbdKQKHf (ORCPT ); Fri, 17 Nov 2017 05:07:35 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41284 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbdKQKH2 (ORCPT ); Fri, 17 Nov 2017 05:07:28 -0500 Date: Fri, 17 Nov 2017 11:07:32 +0100 From: Greg Kroah-Hartman To: Thomas Gleixner Cc: LKML , Linus Torvalds , Andrew Morton , Jonathan Corbet , Kate Stewart , Philippe Ombredanne , Christoph Hellwig , Russell King , Rob Herring , Jonas Oberg , Joe Perches , linux-xfs@vger.kernel.org, Charlemagne Lasse , Carmen Bianca Bakker Subject: Re: [patch V2 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses Message-ID: <20171117100732.GA14762@kroah.com> References: <20171116183306.103584007@linutronix.de> <20171116184358.398030394@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171116184358.398030394@linutronix.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 07:33:07PM +0100, Thomas Gleixner wrote: > +2. Style: > + > + The SPDX license identifier is added in form of a comment. The comment > + style depends on the file type: > + > + :: > + > + C source: // SPDX-License-Identifier: > + C header: /* SPDX-License-Identifier: */ > + ASM: /* SPDX-License-Identifier: */ > + scripts: # SPDX-License-Identifier: > + .rst: .. SPDX-License-Identifier: Minor nit, do you want a tab there on the .rst line or should it be all spaces like the other lines above it to make things line up properly? Otherwise, looks great to me: Reviewed-by: Greg Kroah-Hartman