From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947214AbdKRNRN (ORCPT ); Sat, 18 Nov 2017 08:17:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36046 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947199AbdKRNRF (ORCPT ); Sat, 18 Nov 2017 08:17:05 -0500 Date: Sat, 18 Nov 2017 07:17:00 -0600 From: Josh Poimboeuf To: Juergen Gross Cc: Borislav Petkov , x86@kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Linus Torvalds , Sasha Levin , live-patching@vger.kernel.org, Jiri Slaby , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , Mike Galbraith , Alok Kataria , Rusty Russell , virtualization@lists.linux-foundation.org, Boris Ostrovsky , xen-devel@lists.xenproject.org, Thomas Gleixner Subject: Re: [PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros Message-ID: <20171118131700.y4iv3iepni6jwfc4@treble> References: <20171117180713.e4up3dwrszpatka6@pd.tnic> <20171117194231.576qqr3wnkgowdln@treble> <4022805e-38b2-869c-a766-b7e5026a263e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4022805e-38b2-869c-a766-b7e5026a263e@suse.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sat, 18 Nov 2017 13:17:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 18, 2017 at 11:20:06AM +0100, Juergen Gross wrote: > >>>> +#define NATIVE_ZERO "xor " _REG_ARG1 ", " _REG_ARG1 > >>> > >>> NATIVE_ZERO_OUT > >>> > >>> I guess. NATIVE_ZERO reads like the native representation of 0 :-) > >> > >> NATIVE_ZERO_ARG1? > > > > On a slight tangent, does anybody know why it zeros the arg? > > Why are _you_ asking? You've introduced it. So I did. Touché! > > The only place it's used is here: > > > > #if defined(CONFIG_PARAVIRT_SPINLOCKS) > > DEF_NATIVE(pv_lock_ops, queued_spin_unlock, NATIVE_QUEUED_SPIN_UNLOCK); > > DEF_NATIVE(pv_lock_ops, vcpu_is_preempted, NATIVE_ZERO); > > #endif > > > > Isn't that a bug? Seems like it should _return_ zero. Zeroing the arg > > shouldn't have any effect. > > Right. Before that patch it _did_ return zero instead of zeroing arg1. Oops! > > If I'm right, we could call it NATIVE_FALSE. > > I'd prefer NATIVE_ZERO, as it will be usable for non-boolean cases, too. NATIVE_ZERO works for me. -- Josh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Poimboeuf Subject: Re: [PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros Date: Sat, 18 Nov 2017 07:17:00 -0600 Message-ID: <20171118131700.y4iv3iepni6jwfc4@treble> References: <20171117180713.e4up3dwrszpatka6@pd.tnic> <20171117194231.576qqr3wnkgowdln@treble> <4022805e-38b2-869c-a766-b7e5026a263e@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <4022805e-38b2-869c-a766-b7e5026a263e@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Juergen Gross Cc: Boris Ostrovsky , Rusty Russell , Mike Galbraith , Thomas Gleixner , xen-devel@lists.xenproject.org, Peter Zijlstra , Jiri Slaby , x86@kernel.org, linux-kernel@vger.kernel.org, Sasha Levin , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , live-patching@vger.kernel.org, Alok Kataria , virtualization@lists.linux-foundation.org, Linus Torvalds , Ingo Molnar List-Id: virtualization@lists.linuxfoundation.org T24gU2F0LCBOb3YgMTgsIDIwMTcgYXQgMTE6MjA6MDZBTSArMDEwMCwgSnVlcmdlbiBHcm9zcyB3 cm90ZToKPiA+Pj4+ICsjZGVmaW5lIE5BVElWRV9aRVJPCQkJInhvciAiIF9SRUdfQVJHMSAiLCAi IF9SRUdfQVJHMQo+ID4+Pgo+ID4+PiBOQVRJVkVfWkVST19PVVQKPiA+Pj4KPiA+Pj4gSSBndWVz cy4gTkFUSVZFX1pFUk8gcmVhZHMgbGlrZSB0aGUgbmF0aXZlIHJlcHJlc2VudGF0aW9uIG9mIDAg Oi0pCj4gPj4KPiA+PiBOQVRJVkVfWkVST19BUkcxPwo+ID4gCj4gPiBPbiBhIHNsaWdodCB0YW5n ZW50LCBkb2VzIGFueWJvZHkga25vdyB3aHkgaXQgemVyb3MgdGhlIGFyZz8KPiAKPiBXaHkgYXJl IF95b3VfIGFza2luZz8gWW91J3ZlIGludHJvZHVjZWQgaXQuCgpTbyBJIGRpZC4gIFRvdWNow6kh Cgo+ID4gVGhlIG9ubHkgcGxhY2UgaXQncyB1c2VkIGlzIGhlcmU6Cj4gPiAKPiA+ICNpZiBkZWZp bmVkKENPTkZJR19QQVJBVklSVF9TUElOTE9DS1MpCj4gPiBERUZfTkFUSVZFKHB2X2xvY2tfb3Bz LAlxdWV1ZWRfc3Bpbl91bmxvY2ssCU5BVElWRV9RVUVVRURfU1BJTl9VTkxPQ0spOwo+ID4gREVG X05BVElWRShwdl9sb2NrX29wcywJdmNwdV9pc19wcmVlbXB0ZWQsCU5BVElWRV9aRVJPKTsKPiA+ ICNlbmRpZgo+ID4gCj4gPiBJc24ndCB0aGF0IGEgYnVnPyAgU2VlbXMgbGlrZSBpdCBzaG91bGQg X3JldHVybl8gemVyby4gIFplcm9pbmcgdGhlIGFyZwo+ID4gc2hvdWxkbid0IGhhdmUgYW55IGVm ZmVjdC4KPiAKPiBSaWdodC4gQmVmb3JlIHRoYXQgcGF0Y2ggaXQgX2RpZF8gcmV0dXJuIHplcm8g aW5zdGVhZCBvZiB6ZXJvaW5nIGFyZzEuCgpPb3BzIQoKPiA+IElmIEknbSByaWdodCwgd2UgY291 bGQgY2FsbCBpdCBOQVRJVkVfRkFMU0UuCj4gCj4gSSdkIHByZWZlciBOQVRJVkVfWkVSTywgYXMg aXQgd2lsbCBiZSB1c2FibGUgZm9yIG5vbi1ib29sZWFuIGNhc2VzLCB0b28uCgpOQVRJVkVfWkVS TyB3b3JrcyBmb3IgbWUuCgotLSAKSm9zaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRp b25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRp b24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=