Re: [RFC PATCH v2 0/7] ndctl: nvdimmd: notify/monitor the feathers of over threshold event

[Yasunori Goto <y-goto@jp.fujitsu.com>]

> On Mon, Nov 13, 2017 at 11:46 PM, QI Fuli <qi.fuli@jp.fujitsu.com> wrote:
> > Hi, here is my second version of nvdimm daemon, It would be appreciated
> > if you could check it.
> >
> > Change log since v1:
> >  - Adding a config file(/etc/nvdimmd/nvdimmd.conf)
> >  - Using struct log_ctx instead of syslog()
> >    - Using log_syslog() to save the notify messages to syslog
> >    - Using log_file() to save the notify messages to special file
> >  - Adding LOG_NOTICE level into log_priority
> >  - Using automake instead of Makefile
> >  - Adding a new util file(nvdimmd/util.c) including helper functions needed
> >    for nvdimm daemon.
> >  - Adding nvdimmd_test program
> >
> > ---
> > This is a patch set of nvdimmd, a tiny daemon to monitor the features of over
> > threshold events. When an over thershold event fires, nvdimmd will output the
> > notification including dimm health status to syslog or a special file to
> > users' configuration. Users can choose the output format to be structured json
> > or text.
> >
> > Here are out put samples.
> > - json format:
> > 2017/11/10 11:15:03 [28065] log_notify: nvdimm dimm over threshold notify
> > {
> >   "dev":"nmem1",
> >   "id":"cdab-0a-07e0-feffffff",
> >   "handle":1,
> >   "phys_id":1,
> >   "health":{
> >     "health_state":"non-critical",
> >     "temperature_celsius":23,
> >     "spares_percentage":75,
> >     "alarm_temperature":true,
> >     "alarm_spares":true,
> >     "temperature_threshold":40,
> >     "spares_threshold":5,
> >     "life_used_percentage":5,
> >     "shutdown_state":"clean"
> >   }
> > }
> > - text format:
> > 2017/11/10 16:21:53 [12479] log_notify: nvdimm dimm over threshold notify
> > dev: nmem1
> >  health_state: non-critical
> >  spares_percentage: 75
> 
> Are these formats that services like Scribe and Fluent can consume?
> I'd like to see a sample hook up to those applications.
> 
> I'm also wondering that since this will be a long running service that
> may gain more functionality over time, if we should write it in a
> language that does not have the security sharp edges of C.
> 
> I've been looking for an excuse to use the Go language on a project,
> and this seems a good opportunity.

Hmmmmm, This seems to be big change of direction of nvdimmd.

Certainly, go-lang is good and interesting language in my impression.
But, if nvdimmd is re-created by go-lang, I suppose nvdimmd will need to
discard many functions of ndctl libraries, and need to re-create them by golang.

(Though golang may be able to link C-lang libraries, then its security
 will be simlar with C-lang level, not go-lang level, I think.)

Do you intent that we should re-create many functions for golang?

In addition, do you include source code of go-lang nvdimmd in ndctl source code?


Thanks,


> 
> >
> > TODO list:
> >  - The dimms to monitor should be filtered by namespace and region
> 
> Yes, I'd like to make this equivalent to 'ndctl list' in terms filtering.
> 
> >  - Add more information into the notify message
> >  - Make nvdimmd_test an ndctl command or an option of ndctl inject-error
> 
> Yes, the test events should originate from "ndctl inject-error".
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm



_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm