From: Wolfram Sang <wsa@the-dreams.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mmc@vger.kernel.org,
Simon Horman <simon.horman@netronome.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 4/6] mmc: tmio: move mmc_host_ops to struct tmio_mmc_host from static data
Date: Mon, 20 Nov 2017 21:45:00 +0100 [thread overview]
Message-ID: <20171120204500.gqysj63b32rveahm@ninjato> (raw)
In-Reply-To: <1510042172-27220-5-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Tue, Nov 07, 2017 at 05:09:30PM +0900, Masahiro Yamada wrote:
> Currently, tmio_mmc_ops is static data and tmio_mmc_host_probe()
> updates some hooks in the static data. This is a problem when
> two or more instances call tmio_mmc_host_probe() and each of them
> requests to use its own card_busy/start_signal_voltage_switch.
>
> We can borrow a solution from sdhci_alloc_host(). Copy the whole
> ops structure to host->mmc_host_ops, then override the hooks in
> malloc'ed data. Constify tmio_mmc_ops since it is a template ops
> used by default.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-20 20:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 8:09 [PATCH 0/6] mmc: tmio, renesas_shci: cleanups, core code change for new driver Masahiro Yamada
2017-11-07 8:09 ` [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label Masahiro Yamada
2017-11-20 20:31 ` Wolfram Sang
2017-11-21 3:03 ` Masahiro Yamada
2017-11-07 8:09 ` [PATCH 2/6] mmc: tmio: set tmio_mmc_host to driver data Masahiro Yamada
2017-11-19 19:49 ` Wolfram Sang
2017-11-20 8:18 ` Masahiro Yamada
2017-11-20 9:20 ` Wolfram Sang
2017-11-20 9:30 ` Masahiro Yamada
2017-11-20 13:22 ` Wolfram Sang
2017-11-20 15:14 ` Masahiro Yamada
2017-11-20 20:40 ` Wolfram Sang
2017-11-07 8:09 ` [PATCH 3/6] mmc: tmio: use devm_ioremap_resource() instead of devm_ioremap() Masahiro Yamada
2017-11-20 20:42 ` Wolfram Sang
2017-11-07 8:09 ` [PATCH 4/6] mmc: tmio: move mmc_host_ops to struct tmio_mmc_host from static data Masahiro Yamada
2017-11-20 20:45 ` Wolfram Sang [this message]
2017-11-20 20:48 ` Wolfram Sang
2017-11-23 4:18 ` Masahiro Yamada
2017-11-07 8:09 ` [PATCH 5/6] mmc: tmio, renesas_sdhi: set mmc_host_ops hooks directly Masahiro Yamada
2017-11-20 20:46 ` Wolfram Sang
2017-11-07 8:09 ` [PATCH 6/6] mmc: tmio: move mmc_of_parse() out of tmio_mmc_host_probe() Masahiro Yamada
2017-11-20 20:47 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120204500.gqysj63b32rveahm@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.