From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751963AbdKUJ2L (ORCPT ); Tue, 21 Nov 2017 04:28:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbdKUJ2I (ORCPT ); Tue, 21 Nov 2017 04:28:08 -0500 Date: Tue, 21 Nov 2017 10:28:06 +0100 From: Jiri Olsa To: Andi Kleen Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] perf, tools, script: Allow computing metrics in perf script Message-ID: <20171121092806.GA25279@krava> References: <20171117214300.32746-1-andi@firstfloor.org> <20171117214300.32746-4-andi@firstfloor.org> <20171120090419.GB5684@krava> <20171120153505.GJ2482@two.firstfloor.org> <20171120155345.GB13495@krava> <20171120160306.GG28112@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171120160306.GG28112@tassilo.jf.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 21 Nov 2017 09:28:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 08:03:06AM -0800, Andi Kleen wrote: > > > Yes it is. > > > > > > It's for the complete sampling period because it is computed > > > over the delta from the last sample to the previous sample. > > > > > > There isn't really a metric at a point, it is always over a interval. > > > > agreed, it's the count we meassured from the last sample.. but the > > 'averaged' word above implies to me we compute some average over the > > 'sampling' period, which we dont do > > Do you have a better word in mind? > > AFAIK average is the right word for this because it's the summary > for that time period. the way I understand it is that we take the values from the current sample and count the metric value.. so the phrase: .. the metric computed is averaged over the whole sampling period, not just for the sample point ... does not make sense to me.. because we take the value of that single 'sample point'.. I dont see any average sum in there but my english might be borken and you mean that in a different way jirka