From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751802AbdKUPS1 (ORCPT ); Tue, 21 Nov 2017 10:18:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60196 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbdKUPS0 (ORCPT ); Tue, 21 Nov 2017 10:18:26 -0500 Date: Tue, 21 Nov 2017 16:18:23 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation Message-ID: <20171121151823.GL20440@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-9-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511189024-19908-9-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 21 Nov 2017 15:18:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote: SNIP > diff --git a/tools/perf/util/target.h b/tools/perf/util/target.h > index 446aa7a..6ef01a8 100644 > --- a/tools/perf/util/target.h > +++ b/tools/perf/util/target.h > @@ -64,6 +64,11 @@ static inline bool target__none(struct target *target) > return !target__has_task(target) && !target__has_cpu(target); > } > > +static inline bool target__has_per_thread(struct target *target) > +{ > + return target->system_wide && target->per_thread; > +} this is confusing.. has_per_thread depends on system_wide? > + > static inline bool target__uses_dummy_map(struct target *target) > { > bool use_dummy = false; > @@ -73,6 +78,8 @@ static inline bool target__uses_dummy_map(struct target *target) > else if (target__has_task(target) || > (!target__has_cpu(target) && !target->uses_mmap)) > use_dummy = true; > + else if (target__has_per_thread(target)) > + use_dummy = true; why do we need dummy_map for this? please comment thanks, jirka