* [PATCH 1/2] generic/470: Test RWF_NOWAIT
@ 2017-11-22 12:32 Goldwyn Rodrigues
2017-11-22 12:32 ` [PATCH 2/2] generic/471: Partial direct write test Goldwyn Rodrigues
2017-11-22 17:42 ` [PATCH 1/2] generic/470: Test RWF_NOWAIT Darrick J. Wong
0 siblings, 2 replies; 5+ messages in thread
From: Goldwyn Rodrigues @ 2017-11-22 12:32 UTC (permalink / raw)
To: fstests; +Cc: Goldwyn Rodrigues
From: Goldwyn Rodrigues <rgoldwyn@suse.com>
Tests the RWF_NOWAIT flag so the I/O returns immediately with -EAGAIN
on a new file since it requires block allocation.
It creates a file, syncs it, and overwrites the file with RWF_NOWAIT.
This should succeed.
Finally, read the contents to make sure the overwrite is successful.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
tests/generic/470 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++
tests/generic/470.out | 9 +++++++
tests/generic/group | 1 +
3 files changed, 83 insertions(+)
create mode 100644 tests/generic/470
create mode 100644 tests/generic/470.out
diff --git a/tests/generic/470 b/tests/generic/470
new file mode 100644
index 00000000..8a742258
--- /dev/null
+++ b/tests/generic/470
@@ -0,0 +1,73 @@
+#! /bin/bash
+# FS QA Test No. 470
+#
+# write() to a file opened with O_DIRECT with count > remaining
+# bytes. Result should be remaining bytes (to aligned bytes) instead
+# of ENOSPC error
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -rf $tmp.* $testdir1
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/populate
+. ./common/filter
+. ./common/attr
+
+# real QA test starts here
+_supported_os Linux
+_require_odirect
+_require_scratch
+
+_scratch_mkfs > /dev/null 2>&1
+_scratch_mount > /dev/null 2>&1
+testdir=$SCRATCH_MNT/test-$seq
+mkdir $testdir
+
+# Create a file with pwrite nowait (will fail with EAGAIN)
+xfs_io -f -d -c "pwrite -N -V 1 -b 128M 0 128M" $testdir/f1
+
+# Write the file without nowait
+xfs_io -f -d -c "pwrite -S 0xaa -W -w -V 1 -b 128M 0 128M" $testdir/f1 | _filter_xfs_io
+
+time_taken=`xfs_io -d -c "pwrite -N -V 1 -b 64M 0 64M" $testdir/f1 | awk '/^64/ {print $5}'`
+if (( $(echo "$time_taken < 0.05" | bc -l) )); then
+ echo "RWF_NOWAIT time is within limits."
+else
+ echo "RWF_NOWAIT took $time_taken seconds"
+fi
+
+xfs_io -f -d -c "pread -v 0 2M" $testdir/f1 | _filter_xfs_io_unique
+
+# success, all done
+status=0
+exit
diff --git a/tests/generic/470.out b/tests/generic/470.out
new file mode 100644
index 00000000..73a210b4
--- /dev/null
+++ b/tests/generic/470.out
@@ -0,0 +1,9 @@
+QA output created by 470
+pwrite: Resource temporarily unavailable
+wrote 134217728/134217728 bytes at offset 0
+XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+RWF_NOWAIT time is within limits.
+00000000: cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ................
+*
+read 2097152/2097152 bytes at offset 0
+XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
diff --git a/tests/generic/group b/tests/generic/group
index 6c3bb03a..11ccfb01 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -472,3 +472,4 @@
467 auto quick exportfs
468 shutdown auto quick metadata
469 auto quick
+470 auto quick
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] generic/471: Partial direct write test
2017-11-22 12:32 [PATCH 1/2] generic/470: Test RWF_NOWAIT Goldwyn Rodrigues
@ 2017-11-22 12:32 ` Goldwyn Rodrigues
2017-11-22 17:47 ` Darrick J. Wong
2017-11-22 17:42 ` [PATCH 1/2] generic/470: Test RWF_NOWAIT Darrick J. Wong
1 sibling, 1 reply; 5+ messages in thread
From: Goldwyn Rodrigues @ 2017-11-22 12:32 UTC (permalink / raw)
To: fstests; +Cc: Goldwyn Rodrigues
From: Goldwyn Rodrigues <rgoldwyn@suse.com>
Getting an error midway through a direct write would return an error
and the error-code is returned in the write() call. However, partial
data is over-written during the call.
This tests simulates the ENOSPC error to check for partial direct
write consistency.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
tests/generic/470 | 0
tests/generic/471 | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++
tests/generic/471.out | 9 ++++++
tests/generic/group | 1 +
4 files changed, 99 insertions(+)
mode change 100644 => 100755 tests/generic/470
create mode 100755 tests/generic/471
create mode 100644 tests/generic/471.out
diff --git a/tests/generic/470 b/tests/generic/470
old mode 100644
new mode 100755
diff --git a/tests/generic/471 b/tests/generic/471
new file mode 100755
index 00000000..79ad70a6
--- /dev/null
+++ b/tests/generic/471
@@ -0,0 +1,89 @@
+#! /bin/bash
+# FS QA Test No. 471
+#
+# write() to a file opened with O_DIRECT with count > remaining
+# bytes. Result should be either the write should return remaining bytes
+# (to aligned bytes) instead of ENOSPC error.
+#
+# Fixes: Direct write() returns error but file contents are updated
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -rf $tmp.* $testdir1
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/populate
+. ./common/filter
+. ./common/attr
+
+# real QA test starts here
+_supported_os Linux
+_require_odirect
+
+rm -f $seqres.full
+
+echo "Reformat with 320M size"
+umount $SCRATCH_MNT
+sz_bytes=$((320 * 1024 * 1024))
+_scratch_mkfs_sized $sz_bytes >> $seqres.full 2>&1
+_scratch_mount >> $seqres.full 2>&1
+testdir=$SCRATCH_MNT/test-$seq
+rm -rf $testdir
+mkdir $testdir
+sync
+
+#Almost fill the filesystem
+echo "Almost fill the filesystem"
+for i in `seq 1 5`; do
+ $XFS_IO_PROG -f -c "pwrite 0 40M" $testdir/file-$i > /dev/null
+done
+
+# Create a file using buffered I/O which succeeds only partially
+$XFS_IO_PROG -f -c "pwrite -w -S 0xaa 0 128M" $testdir/partial
+
+# re-write using direct I/O with default pattern using one single buffer
+write_size=`$XFS_IO_PROG -d -c "pwrite -O -V 1 -b 128M 0 128M" $testdir/partial | awk '/^wrote/ {split($2, bytes, "/"); print bytes[1]}'`
+if [ -z $write_size ]; then
+ write_size=0
+fi
+if [ $write_size -gt 0 ]; then
+ echo "pwrite wrote more than zero bytes."
+else
+ echo "pwrite wrote $write_size"
+fi
+
+# read the partial file to check if data written is correct
+$XFS_IO_PROG -d -c "pread 0 2M -v" $testdir/partial | _filter_xfs_io_unique
+
+# success, all done
+status=0
+exit
diff --git a/tests/generic/471.out b/tests/generic/471.out
new file mode 100644
index 00000000..e01687c8
--- /dev/null
+++ b/tests/generic/471.out
@@ -0,0 +1,9 @@
+QA output created by 471
+Reformat with 320M size
+Almost fill the filesystem
+pwrite: No space left on device
+pwrite wrote more than zero bytes.
+00000000: cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ................
+*
+read 2097152/2097152 bytes at offset 0
+XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
diff --git a/tests/generic/group b/tests/generic/group
index 11ccfb01..f4591620 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -473,3 +473,4 @@
468 shutdown auto quick metadata
469 auto quick
470 auto quick
+471 auto quick rw
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] generic/470: Test RWF_NOWAIT
2017-11-22 12:32 [PATCH 1/2] generic/470: Test RWF_NOWAIT Goldwyn Rodrigues
2017-11-22 12:32 ` [PATCH 2/2] generic/471: Partial direct write test Goldwyn Rodrigues
@ 2017-11-22 17:42 ` Darrick J. Wong
2017-11-23 15:28 ` Goldwyn Rodrigues
1 sibling, 1 reply; 5+ messages in thread
From: Darrick J. Wong @ 2017-11-22 17:42 UTC (permalink / raw)
To: Goldwyn Rodrigues; +Cc: fstests, Goldwyn Rodrigues
On Wed, Nov 22, 2017 at 06:32:14AM -0600, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> Tests the RWF_NOWAIT flag so the I/O returns immediately with -EAGAIN
> on a new file since it requires block allocation.
>
> It creates a file, syncs it, and overwrites the file with RWF_NOWAIT.
> This should succeed.
>
> Finally, read the contents to make sure the overwrite is successful.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> ---
> tests/generic/470 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/470.out | 9 +++++++
> tests/generic/group | 1 +
> 3 files changed, 83 insertions(+)
> create mode 100644 tests/generic/470
> create mode 100644 tests/generic/470.out
>
> diff --git a/tests/generic/470 b/tests/generic/470
> new file mode 100644
> index 00000000..8a742258
> --- /dev/null
> +++ b/tests/generic/470
> @@ -0,0 +1,73 @@
> +#! /bin/bash
> +# FS QA Test No. 470
> +#
> +# write() to a file opened with O_DIRECT with count > remaining
> +# bytes. Result should be remaining bytes (to aligned bytes) instead
> +# of ENOSPC error
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#-----------------------------------------------------------------------
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -rf $tmp.* $testdir1
$testdir, not $testdir1?
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/populate
> +. ./common/filter
> +. ./common/attr
> +
> +# real QA test starts here
> +_supported_os Linux
> +_require_odirect
> +_require_scratch
> +
> +_scratch_mkfs > /dev/null 2>&1
> +_scratch_mount > /dev/null 2>&1
> +testdir=$SCRATCH_MNT/test-$seq
> +mkdir $testdir
> +
> +# Create a file with pwrite nowait (will fail with EAGAIN)
> +xfs_io -f -d -c "pwrite -N -V 1 -b 128M 0 128M" $testdir/f1
$XFS_IO_PROG, not xfs_io
Also does this test need _require_xfs_io_command pwrite -N ?
> +
> +# Write the file without nowait
> +xfs_io -f -d -c "pwrite -S 0xaa -W -w -V 1 -b 128M 0 128M" $testdir/f1 | _filter_xfs_io
> +
> +time_taken=`xfs_io -d -c "pwrite -N -V 1 -b 64M 0 64M" $testdir/f1 | awk '/^64/ {print $5}'`
> +if (( $(echo "$time_taken < 0.05" | bc -l) )); then
We're assuming that the hardware is capable of handling a direct write
64M in under 51ms, correct? I'm not sure my disks can do that.
--D
> + echo "RWF_NOWAIT time is within limits."
> +else
> + echo "RWF_NOWAIT took $time_taken seconds"
> +fi
> +
> +xfs_io -f -d -c "pread -v 0 2M" $testdir/f1 | _filter_xfs_io_unique
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/generic/470.out b/tests/generic/470.out
> new file mode 100644
> index 00000000..73a210b4
> --- /dev/null
> +++ b/tests/generic/470.out
> @@ -0,0 +1,9 @@
> +QA output created by 470
> +pwrite: Resource temporarily unavailable
> +wrote 134217728/134217728 bytes at offset 0
> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +RWF_NOWAIT time is within limits.
> +00000000: cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ................
> +*
> +read 2097152/2097152 bytes at offset 0
> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> diff --git a/tests/generic/group b/tests/generic/group
> index 6c3bb03a..11ccfb01 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -472,3 +472,4 @@
> 467 auto quick exportfs
> 468 shutdown auto quick metadata
> 469 auto quick
> +470 auto quick
> --
> 2.14.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] generic/471: Partial direct write test
2017-11-22 12:32 ` [PATCH 2/2] generic/471: Partial direct write test Goldwyn Rodrigues
@ 2017-11-22 17:47 ` Darrick J. Wong
0 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2017-11-22 17:47 UTC (permalink / raw)
To: Goldwyn Rodrigues; +Cc: fstests, Goldwyn Rodrigues
On Wed, Nov 22, 2017 at 06:32:15AM -0600, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> Getting an error midway through a direct write would return an error
> and the error-code is returned in the write() call. However, partial
> data is over-written during the call.
>
> This tests simulates the ENOSPC error to check for partial direct
> write consistency.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> ---
> tests/generic/470 | 0
> tests/generic/471 | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/471.out | 9 ++++++
> tests/generic/group | 1 +
> 4 files changed, 99 insertions(+)
> mode change 100644 => 100755 tests/generic/470
> create mode 100755 tests/generic/471
> create mode 100644 tests/generic/471.out
>
> diff --git a/tests/generic/470 b/tests/generic/470
> old mode 100644
> new mode 100755
Belongs in previous patch.
> diff --git a/tests/generic/471 b/tests/generic/471
> new file mode 100755
> index 00000000..79ad70a6
> --- /dev/null
> +++ b/tests/generic/471
> @@ -0,0 +1,89 @@
> +#! /bin/bash
> +# FS QA Test No. 471
> +#
> +# write() to a file opened with O_DIRECT with count > remaining
> +# bytes. Result should be either the write should return remaining bytes
> +# (to aligned bytes) instead of ENOSPC error.
> +#
> +# Fixes: Direct write() returns error but file contents are updated
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#-----------------------------------------------------------------------
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -rf $tmp.* $testdir1
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/populate
> +. ./common/filter
> +. ./common/attr
> +
> +# real QA test starts here
> +_supported_os Linux
> +_require_odirect
> +
> +rm -f $seqres.full
> +
> +echo "Reformat with 320M size"
> +umount $SCRATCH_MNT
> +sz_bytes=$((320 * 1024 * 1024))
> +_scratch_mkfs_sized $sz_bytes >> $seqres.full 2>&1
> +_scratch_mount >> $seqres.full 2>&1
> +testdir=$SCRATCH_MNT/test-$seq
> +rm -rf $testdir
> +mkdir $testdir
> +sync
> +
> +#Almost fill the filesystem
> +echo "Almost fill the filesystem"
> +for i in `seq 1 5`; do
> + $XFS_IO_PROG -f -c "pwrite 0 40M" $testdir/file-$i > /dev/null
> +done
_fill_fs ?
Or, why not just write one 200M file and sync it?
--D
> +
> +# Create a file using buffered I/O which succeeds only partially
> +$XFS_IO_PROG -f -c "pwrite -w -S 0xaa 0 128M" $testdir/partial
> +
> +# re-write using direct I/O with default pattern using one single buffer
> +write_size=`$XFS_IO_PROG -d -c "pwrite -O -V 1 -b 128M 0 128M" $testdir/partial | awk '/^wrote/ {split($2, bytes, "/"); print bytes[1]}'`
> +if [ -z $write_size ]; then
> + write_size=0
> +fi
> +if [ $write_size -gt 0 ]; then
> + echo "pwrite wrote more than zero bytes."
> +else
> + echo "pwrite wrote $write_size"
> +fi
> +
> +# read the partial file to check if data written is correct
> +$XFS_IO_PROG -d -c "pread 0 2M -v" $testdir/partial | _filter_xfs_io_unique
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/generic/471.out b/tests/generic/471.out
> new file mode 100644
> index 00000000..e01687c8
> --- /dev/null
> +++ b/tests/generic/471.out
> @@ -0,0 +1,9 @@
> +QA output created by 471
> +Reformat with 320M size
> +Almost fill the filesystem
> +pwrite: No space left on device
> +pwrite wrote more than zero bytes.
> +00000000: cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ................
> +*
> +read 2097152/2097152 bytes at offset 0
> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> diff --git a/tests/generic/group b/tests/generic/group
> index 11ccfb01..f4591620 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -473,3 +473,4 @@
> 468 shutdown auto quick metadata
> 469 auto quick
> 470 auto quick
> +471 auto quick rw
> --
> 2.14.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] generic/470: Test RWF_NOWAIT
2017-11-22 17:42 ` [PATCH 1/2] generic/470: Test RWF_NOWAIT Darrick J. Wong
@ 2017-11-23 15:28 ` Goldwyn Rodrigues
0 siblings, 0 replies; 5+ messages in thread
From: Goldwyn Rodrigues @ 2017-11-23 15:28 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: fstests, Goldwyn Rodrigues
On 11/22/2017 11:42 AM, Darrick J. Wong wrote:
> On Wed, Nov 22, 2017 at 06:32:14AM -0600, Goldwyn Rodrigues wrote:
>> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>>
>> Tests the RWF_NOWAIT flag so the I/O returns immediately with -EAGAIN
>> on a new file since it requires block allocation.
>>
>> It creates a file, syncs it, and overwrites the file with RWF_NOWAIT.
>> This should succeed.
>>
>> Finally, read the contents to make sure the overwrite is successful.
>>
>> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>> ---
>> tests/generic/470 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++
>> tests/generic/470.out | 9 +++++++
>> tests/generic/group | 1 +
>> 3 files changed, 83 insertions(+)
>> create mode 100644 tests/generic/470
>> create mode 100644 tests/generic/470.out
>>
>> diff --git a/tests/generic/470 b/tests/generic/470
>> new file mode 100644
>> index 00000000..8a742258
>> --- /dev/null
>> +++ b/tests/generic/470
>> @@ -0,0 +1,73 @@
>> +#! /bin/bash
>> +# FS QA Test No. 470
>> +#
>> +# write() to a file opened with O_DIRECT with count > remaining
>> +# bytes. Result should be remaining bytes (to aligned bytes) instead
>> +# of ENOSPC error
>> +#
>> +#-----------------------------------------------------------------------
>> +# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved.
>> +#
>> +# This program is free software; you can redistribute it and/or
>> +# modify it under the terms of the GNU General Public License as
>> +# published by the Free Software Foundation.
>> +#
>> +# This program is distributed in the hope that it would be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program; if not, write the Free Software Foundation,
>> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
>> +#-----------------------------------------------------------------------
>> +
>> +seq=`basename $0`
>> +seqres=$RESULT_DIR/$seq
>> +echo "QA output created by $seq"
>> +
>> +here=`pwd`
>> +tmp=/tmp/$$
>> +status=1 # failure is the default!
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +_cleanup()
>> +{
>> + cd /
>> + rm -rf $tmp.* $testdir1
>
> $testdir, not $testdir1?
>
>> +}
>> +
>> +# get standard environment, filters and checks
>> +. ./common/rc
>> +. ./common/populate
>> +. ./common/filter
>> +. ./common/attr
>> +
>> +# real QA test starts here
>> +_supported_os Linux
>> +_require_odirect
>> +_require_scratch
>> +
>> +_scratch_mkfs > /dev/null 2>&1
>> +_scratch_mount > /dev/null 2>&1
>> +testdir=$SCRATCH_MNT/test-$seq
>> +mkdir $testdir
>> +
>> +# Create a file with pwrite nowait (will fail with EAGAIN)
>> +xfs_io -f -d -c "pwrite -N -V 1 -b 128M 0 128M" $testdir/f1
>
> $XFS_IO_PROG, not xfs_io
>
> Also does this test need _require_xfs_io_command pwrite -N ?
Yes, I was looking for something with version compatibility. Thanks.
>
>> +
>> +# Write the file without nowait
>> +xfs_io -f -d -c "pwrite -S 0xaa -W -w -V 1 -b 128M 0 128M" $testdir/f1 | _filter_xfs_io
>> +
>> +time_taken=`xfs_io -d -c "pwrite -N -V 1 -b 64M 0 64M" $testdir/f1 | awk '/^64/ {print $5}'`
>> +if (( $(echo "$time_taken < 0.05" | bc -l) )); then
>
> We're assuming that the hardware is capable of handling a direct write
> 64M in under 51ms, correct? I'm not sure my disks can do that.
Yes, though a little different. The blocks are already allocated so it
should be fast. I will add a comment.
>
> --D
>
>> + echo "RWF_NOWAIT time is within limits."
>> +else
>> + echo "RWF_NOWAIT took $time_taken seconds"
>> +fi
>> +
>> +xfs_io -f -d -c "pread -v 0 2M" $testdir/f1 | _filter_xfs_io_unique
>> +
>> +# success, all done
>> +status=0
>> +exit
>> diff --git a/tests/generic/470.out b/tests/generic/470.out
>> new file mode 100644
>> index 00000000..73a210b4
>> --- /dev/null
>> +++ b/tests/generic/470.out
>> @@ -0,0 +1,9 @@
>> +QA output created by 470
>> +pwrite: Resource temporarily unavailable
>> +wrote 134217728/134217728 bytes at offset 0
>> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> +RWF_NOWAIT time is within limits.
>> +00000000: cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ................
>> +*
>> +read 2097152/2097152 bytes at offset 0
>> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> diff --git a/tests/generic/group b/tests/generic/group
>> index 6c3bb03a..11ccfb01 100644
>> --- a/tests/generic/group
>> +++ b/tests/generic/group
>> @@ -472,3 +472,4 @@
>> 467 auto quick exportfs
>> 468 shutdown auto quick metadata
>> 469 auto quick
>> +470 auto quick
>> --
>> 2.14.2
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Goldwyn
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-23 15:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-22 12:32 [PATCH 1/2] generic/470: Test RWF_NOWAIT Goldwyn Rodrigues
2017-11-22 12:32 ` [PATCH 2/2] generic/471: Partial direct write test Goldwyn Rodrigues
2017-11-22 17:47 ` Darrick J. Wong
2017-11-22 17:42 ` [PATCH 1/2] generic/470: Test RWF_NOWAIT Darrick J. Wong
2017-11-23 15:28 ` Goldwyn Rodrigues
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.