From: Christoph Hellwig <hch@infradead.org>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org, sandeen@redhat.com,
darrick.wong@oracle.com
Subject: Re: [PATCH] xfs: Don't trim file extents during iomap
Date: Thu, 23 Nov 2017 05:26:06 -0800 [thread overview]
Message-ID: <20171123132606.GA21798@infradead.org> (raw)
In-Reply-To: <1511437203-4329-1-git-send-email-nborisov@suse.com>
On Thu, Nov 23, 2017 at 01:40:03PM +0200, Nikolay Borisov wrote:
> For file extents xfs currently calls xfs_bmapi_read with flag set to 0,
> meaning extents are going to be truncated to the requested range. Since the
> same codepath is used for fiemap this means xfs is special in that regard, since
> other filesystems (ext4/btrfs) do not trim extents for fiemap. Make the behavior
> consistent by always passing XFS_BMAPI_ENTIRE. A full xfstest run validated that
> this doesn't regress on ordinary read/write IO.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Looks good, except that the changelog could use line wrapping at
75 characters :)
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-11-23 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 11:40 [PATCH] xfs: Don't trim file extents during iomap Nikolay Borisov
2017-11-23 13:26 ` Christoph Hellwig [this message]
2017-11-27 17:44 ` Darrick J. Wong
2017-11-28 1:47 ` Darrick J. Wong
2017-11-28 6:46 ` Nikolay Borisov
2017-11-29 2:30 ` Darrick J. Wong
2017-11-29 19:57 ` Christoph Hellwig
2017-11-28 7:05 ` Nikolay Borisov
2017-11-28 9:17 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123132606.GA21798@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.