From: Michal Hocko <mhocko@kernel.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fs: handle shrinker registration failure in sget_userns
Date: Thu, 23 Nov 2017 16:00:52 +0100 [thread overview]
Message-ID: <20171123150052.b6k4tx46cf3wk5lk@dhcp22.suse.cz> (raw)
In-Reply-To: <20171123144735.GA21978@ZenIV.linux.org.uk>
On Thu 23-11-17 14:47:35, Al Viro wrote:
> On Thu, Nov 23, 2017 at 12:52:47PM +0100, Michal Hocko wrote:
> > @@ -503,12 +504,18 @@ struct super_block *sget_userns(struct file_system_type *type,
> > s = alloc_super(type, (flags & ~SB_SUBMOUNT), user_ns);
> > if (!s)
> > return ERR_PTR(-ENOMEM);
> > + if (register_shrinker(&s->s_shrink)) {
> > + spin_unlock(&sb_lock);
> > + destroy_unused_super(s);
> > + return ERR_PTR(-ENOMEM);
>
> Have you even tested that? What the hell is that spin_unlock() doing there?
Yeah, that patch was just screwed up. Have a look at
http://lkml.kernel.org/r/20171123143537.ztpxpk3sjbpo72rf@dhcp22.suse.cz
which should even resemble a real patch.
Sorry about all the confusion.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2017-11-23 15:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 11:52 [PATCH] fs: handle shrinker registration failure in sget_userns Michal Hocko
2017-11-23 12:26 ` Jan Kara
2017-11-23 12:45 ` Michal Hocko
2017-11-23 12:53 ` Michal Hocko
2017-11-23 12:56 ` Jan Kara
2017-11-23 13:35 ` Tetsuo Handa
2017-11-23 13:46 ` Michal Hocko
2017-11-23 13:57 ` Tetsuo Handa
2017-11-23 14:06 ` Michal Hocko
2017-11-23 14:10 ` Tetsuo Handa
2017-11-23 14:35 ` [PATCH v2] " Michal Hocko
2017-11-23 14:55 ` Al Viro
2017-11-23 15:02 ` Michal Hocko
2017-11-23 15:34 ` Michal Hocko
2017-11-23 15:04 ` [PATCH v2] fs: handle shrinker registration failure insget_userns Tetsuo Handa
2017-11-23 15:28 ` Al Viro
2017-11-23 15:35 ` [PATCH v2] fs: handle shrinker registration failure in sget_userns Tetsuo Handa
2017-11-23 15:44 ` Al Viro
2017-11-23 21:51 ` Tetsuo Handa
2017-11-24 7:48 ` Michal Hocko
2017-11-29 11:55 ` Michal Hocko
2017-12-09 20:59 ` Al Viro
2017-12-09 21:54 ` Al Viro
2017-12-10 2:33 ` Tetsuo Handa
2017-12-10 10:05 ` Michal Hocko
2017-12-10 15:21 ` Al Viro
2017-11-23 14:47 ` [PATCH] " Al Viro
2017-11-23 15:00 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123150052.b6k4tx46cf3wk5lk@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.