From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harry Wentland Subject: [PATCH 07/43] drm/amd/display: Fix amdgpu_dm bugs found by smatch Date: Thu, 23 Nov 2017 14:52:40 -0500 Message-ID: <20171123195316.8366-8-harry.wentland@amd.com> References: <20171123195316.8366-1-harry.wentland@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171123195316.8366-1-harry.wentland-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Harry Wentland ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2Rt LmM6Mjc2MApjcmVhdGVfZW1sX3NpbmsoKSB3YXJuOiB2YXJpYWJsZSBkZXJlZmVyZW5jZWQgYmVm b3JlIGNoZWNrCidhY29ubmVjdG9yLT5iYXNlLmVkaWRfYmxvYl9wdHInIChzZWUgbGluZSAyNzU4 KQpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVf ZG0uYzo0MjcwCmFtZGdwdV9kbV9hdG9taWNfY29tbWl0X3RhaWwoKSB3YXJuOiB2YXJpYWJsZSBk ZXJlZmVyZW5jZWQgYmVmb3JlIGNoZWNrCidkbV9uZXdfY3J0Y19zdGF0ZS0+c3RyZWFtJyAoc2Vl IGxpbmUgNDI2NikKZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9hbWRncHVf ZG0vYW1kZ3B1X2RtLmM6NDQxNwpkbV9yZXN0b3JlX2RybV9jb25uZWN0b3Jfc3RhdGUoKSB3YXJu OiB2YXJpYWJsZSBkZXJlZmVyZW5jZWQgYmVmb3JlCmNoZWNrICdkaXNjb25uZWN0ZWRfYWNydGMn IChzZWUgbGluZSA0NDE1KQoKU2lnbmVkLW9mZi1ieTogSGFycnkgV2VudGxhbmQgPGhhcnJ5Lndl bnRsYW5kQGFtZC5jb20+ClJldmlld2VkLWJ5OiBTdW4gcGVuZyBMaSA8U3VucGVuZy5MaUBhbWQu Y29tPgpBY2tlZC1ieTogSGFycnkgV2VudGxhbmQgPGhhcnJ5LndlbnRsYW5kQGFtZC5jb20+Ci0t LQogZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYyB8IDE2 ICsrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA2IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRn cHVfZG0vYW1kZ3B1X2RtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2Rt L2FtZGdwdV9kbS5jCmluZGV4IDE5ZTAwZWMzN2RiMy4uYzI2ZWE1NjYxNGRiIDEwMDY0NAotLS0g YS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jCisrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKQEAgLTI3 NTUsNyArMjc1NSw3IEBAIHN0YXRpYyB2b2lkIGNyZWF0ZV9lbWxfc2luayhzdHJ1Y3QgYW1kZ3B1 X2RtX2Nvbm5lY3RvciAqYWNvbm5lY3RvcikKIAkJCS5saW5rID0gYWNvbm5lY3Rvci0+ZGNfbGlu aywKIAkJCS5zaW5rX3NpZ25hbCA9IFNJR05BTF9UWVBFX1ZJUlRVQUwKIAl9OwotCXN0cnVjdCBl ZGlkICplZGlkID0gKHN0cnVjdCBlZGlkICopIGFjb25uZWN0b3ItPmJhc2UuZWRpZF9ibG9iX3B0 ci0+ZGF0YTsKKwlzdHJ1Y3QgZWRpZCAqZWRpZDsKIAogCWlmICghYWNvbm5lY3Rvci0+YmFzZS5l ZGlkX2Jsb2JfcHRyIHx8CiAJCSFhY29ubmVjdG9yLT5iYXNlLmVkaWRfYmxvYl9wdHItPmRhdGEp IHsKQEAgLTI3NjcsNiArMjc2Nyw4IEBAIHN0YXRpYyB2b2lkIGNyZWF0ZV9lbWxfc2luayhzdHJ1 Y3QgYW1kZ3B1X2RtX2Nvbm5lY3RvciAqYWNvbm5lY3RvcikKIAkJcmV0dXJuOwogCX0KIAorCWVk aWQgPSAoc3RydWN0IGVkaWQgKikgYWNvbm5lY3Rvci0+YmFzZS5lZGlkX2Jsb2JfcHRyLT5kYXRh OworCiAJYWNvbm5lY3Rvci0+ZWRpZCA9IGVkaWQ7CiAKIAlhY29ubmVjdG9yLT5kY19lbV9zaW5r ID0gZGNfbGlua19hZGRfcmVtb3RlX3NpbmsoCkBAIC00MjgyLDEzICs0Mjg0LDEzIEBAIHN0YXRp YyB2b2lkIGFtZGdwdV9kbV9hdG9taWNfY29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlKQogCQl1cGRhdGVfc3RyZWFtX3NjYWxpbmdfc2V0dGluZ3MoJmRtX25ld19jb25f c3RhdGUtPmJhc2UuY3J0Yy0+bW9kZSwKIAkJCQlkbV9uZXdfY29uX3N0YXRlLCAoc3RydWN0IGRj X3N0cmVhbV9zdGF0ZSAqKWRtX25ld19jcnRjX3N0YXRlLT5zdHJlYW0pOwogCisJCWlmICghZG1f bmV3X2NydGNfc3RhdGUtPnN0cmVhbSkKKwkJCWNvbnRpbnVlOworCiAJCXN0YXR1cyA9IGRjX3N0 cmVhbV9nZXRfc3RhdHVzKGRtX25ld19jcnRjX3N0YXRlLT5zdHJlYW0pOwogCQlXQVJOX09OKCFz dGF0dXMpOwogCQlXQVJOX09OKCFzdGF0dXMtPnBsYW5lX2NvdW50KTsKIAotCQlpZiAoIWRtX25l d19jcnRjX3N0YXRlLT5zdHJlYW0pCi0JCQljb250aW51ZTsKLQogCQkvKlRPRE8gSG93IGl0IHdv cmtzIHdpdGggTVBPID8qLwogCQlpZiAoIWRjX2NvbW1pdF9wbGFuZXNfdG9fc3RyZWFtKAogCQkJ CWRtLT5kYywKQEAgLTQ0MzEsOSArNDQzMywxMSBAQCB2b2lkIGRtX3Jlc3RvcmVfZHJtX2Nvbm5l Y3Rvcl9zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAogCQlyZXR1cm47CiAKIAlkaXNjb25u ZWN0ZWRfYWNydGMgPSB0b19hbWRncHVfY3J0Yyhjb25uZWN0b3ItPmVuY29kZXItPmNydGMpOwot CWFjcnRjX3N0YXRlID0gdG9fZG1fY3J0Y19zdGF0ZShkaXNjb25uZWN0ZWRfYWNydGMtPmJhc2Uu c3RhdGUpOworCWlmICghZGlzY29ubmVjdGVkX2FjcnRjKQorCQlyZXR1cm47CiAKLQlpZiAoIWRp c2Nvbm5lY3RlZF9hY3J0YyB8fCAhYWNydGNfc3RhdGUtPnN0cmVhbSkKKwlhY3J0Y19zdGF0ZSA9 IHRvX2RtX2NydGNfc3RhdGUoZGlzY29ubmVjdGVkX2FjcnRjLT5iYXNlLnN0YXRlKTsKKwlpZiAo IWFjcnRjX3N0YXRlLT5zdHJlYW0pCiAJCXJldHVybjsKIAogCS8qCi0tIAoyLjE0LjEKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=