From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752888AbdKWNfw (ORCPT ); Thu, 23 Nov 2017 08:35:52 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:14077 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734AbdKWNfu (ORCPT ); Thu, 23 Nov 2017 08:35:50 -0500 To: jack@suse.cz, mhocko@kernel.org Cc: viro@zeniv.linux.org.uk, david@fromorbit.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] fs: handle shrinker registration failure in sget_userns From: Tetsuo Handa References: <20171123115247.30685-1-mhocko@kernel.org> <20171123122616.GC6324@quack2.suse.cz> <20171123124541.sjdkavie47wfahrs@dhcp22.suse.cz> <20171123125345.exih2j4jv4shn3yz@dhcp22.suse.cz> <20171123125626.GD6324@quack2.suse.cz> In-Reply-To: <20171123125626.GD6324@quack2.suse.cz> Message-Id: <201711232235.CDI34369.FLOtQVHFSJOOMF@I-love.SAKURA.ne.jp> X-Mailer: Winbiff [Version 2.51 PL2] X-Accept-Language: ja,en,zh Date: Thu, 23 Nov 2017 22:35:34 +0900 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jan Kara wrote: > Looks good to me now. You can add: > > Reviewed-by: Jan Kara > It does not look good to me, for "goto fail" can call destroy_unused_super() before s->s_shrink.list is initialized. Also, the comment block saying "this object isn't exposed yet" wants to be updated? --- fs/super.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fs/super.c b/fs/super.c index 80b118c..44f0c6b 100644 --- a/fs/super.c +++ b/fs/super.c @@ -197,6 +197,7 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags, if (!s) return NULL; + INIT_LIST_HEAD(&s->s_shrink.list); INIT_LIST_HEAD(&s->s_mounts); s->s_user_ns = get_user_ns(user_ns); @@ -260,9 +261,8 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags, s->s_shrink.count_objects = super_cache_count; s->s_shrink.batch = 1024; s->s_shrink.flags = SHRINKER_NUMA_AWARE | SHRINKER_MEMCG_AWARE; - INIT_LIST_HEAD(&s->s_shrink.list); - return s; - + if (register_shrinker(&s->s_shrink) == 0) + return s; fail: destroy_unused_super(s); return NULL; @@ -512,10 +512,6 @@ struct super_block *sget_userns(struct file_system_type *type, s = alloc_super(type, (flags & ~SB_SUBMOUNT), user_ns); if (!s) return ERR_PTR(-ENOMEM); - if (register_shrinker(&s->s_shrink)) { - destroy_unused_super(s); - return ERR_PTR(-ENOMEM); - } goto retry; } -- 1.8.3.1