From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org, jasowang@redhat.com, mkubecek@suse.cz,
willemb@google.com
Subject: Re: [PATCH net v2] net: accept UFO datagrams from tuntap and packet
Date: Fri, 24 Nov 2017 01:37:58 +0900 (KST) [thread overview]
Message-ID: <20171124.013758.1742079561164230628.davem@davemloft.net> (raw)
In-Reply-To: <20171121152225.83972-1-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Tue, 21 Nov 2017 10:22:25 -0500
> From: Willem de Bruijn <willemb@google.com>
>
> Tuntap and similar devices can inject GSO packets. Accept type
> VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively.
>
> Processes are expected to use feature negotiation such as TUNSETOFFLOAD
> to detect supported offload types and refrain from injecting other
> packets. This process breaks down with live migration: guest kernels
> do not renegotiate flags, so destination hosts need to expose all
> features that the source host does.
>
> Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677.
> This patch introduces nearly(*) no new code to simplify verification.
> It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP
> insertion and software UFO segmentation.
>
> It does not reinstate protocol stack support, hardware offload
> (NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception
> of VIRTIO_NET_HDR_GSO_UDP packets in tuntap.
>
> To support SKB_GSO_UDP reappearing in the stack, also reinstate
> logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD
> by squashing in commit 939912216fa8 ("net: skb_needs_check() removes
> CHECKSUM_UNNECESSARY check for tx.") and reverting commit 8d63bee643f1
> ("net: avoid skb_warn_bad_offload false positives on UFO").
>
> (*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id,
> ipv6_proxy_select_ident is changed to return a __be32 and this is
> assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted
> at the end of the enum to minimize code churn.
...
> Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com>
> Fixes: fb652fdfe837 ("macvlan/macvtap: Remove NETIF_F_UFO advertisement.")
> Reported-by: Michal Kubecek <mkubecek@suse.cz>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2017-11-23 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 15:22 [PATCH net v2] net: accept UFO datagrams from tuntap and packet Willem de Bruijn
2017-11-22 12:54 ` Jason Wang
2017-11-23 16:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124.013758.1742079561164230628.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.