From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753037AbdKXIfe (ORCPT ); Fri, 24 Nov 2017 03:35:34 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:49004 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752926AbdKXIfa (ORCPT ); Fri, 24 Nov 2017 03:35:30 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Date: Fri, 24 Nov 2017 08:34:25 +0000 From: Charles Keepax To: SF Markus Elfring CC: , , "Jaroslav Kysela" , Liam Girdwood , Mark Brown , Takashi Iwai , LKML , Subject: Re: [PATCH 2/4] ASoC: wm2000: One function call less in wm2000_i2c_probe() after error detection Message-ID: <20171124083425.jwjdppt4mpl55r4p@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711240115 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 24, 2017 at 08:37:41AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 24 Nov 2017 07:45:59 +0100 > > The release_firmware() function was called in a few cases by the > wm2000_i2c_probe() function during error handling even if > the passed variable contained a null pointer. > > * Adjust jump targets according to the Linux coding style convention. > > * Delete the label "out" and an initialisation for the variable "fw" > at the beginning which became unnecessary with this refactoring. > > Signed-off-by: Markus Elfring > --- Acked-by: Charles Keepax Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Date: Fri, 24 Nov 2017 08:34:25 +0000 Subject: Re: [PATCH 2/4] ASoC: wm2000: One function call less in wm2000_i2c_probe() after error detection Message-Id: <20171124083425.jwjdppt4mpl55r4p@localhost.localdomain> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , LKML On Fri, Nov 24, 2017 at 08:37:41AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 24 Nov 2017 07:45:59 +0100 > > The release_firmware() function was called in a few cases by the > wm2000_i2c_probe() function during error handling even if > the passed variable contained a null pointer. > > * Adjust jump targets according to the Linux coding style convention. > > * Delete the label "out" and an initialisation for the variable "fw" > at the beginning which became unnecessary with this refactoring. > > Signed-off-by: Markus Elfring > --- Acked-by: Charles Keepax Thanks, Charles