From: "Michał Winiarski" <michal.winiarski@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: Tidy ELSP port assignment
Date: Fri, 24 Nov 2017 13:45:50 +0100 [thread overview]
Message-ID: <20171124124550.7kqlahyntja45cf6@mwiniars-main.ger.corp.intel.com> (raw)
In-Reply-To: <20171124122916.29910-1-chris@chris-wilson.co.uk>
On Fri, Nov 24, 2017 at 12:29:16PM +0000, Chris Wilson wrote:
> Since we know that the port is empty, we do not need to extract the
> count from the old request it and copy it over to the new request, or
> attempt to unref the NULL old request pointer.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
-Michał
> ---
> drivers/gpu/drm/i915/intel_guc_submission.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_submission.c b/drivers/gpu/drm/i915/intel_guc_submission.c
> index cbf5a96f5806..b619e591f8f1 100644
> --- a/drivers/gpu/drm/i915/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/intel_guc_submission.c
> @@ -718,12 +718,9 @@ static void guc_submit(struct intel_engine_cs *engine)
> static void port_assign(struct execlist_port *port,
> struct drm_i915_gem_request *rq)
> {
> - GEM_BUG_ON(rq == port_request(port));
> + GEM_BUG_ON(port_isset(port));
>
> - if (port_isset(port))
> - i915_gem_request_put(port_request(port));
> -
> - port_set(port, port_pack(i915_gem_request_get(rq), port_count(port)));
> + port_set(port, i915_gem_request_get(rq));
> }
>
> static void guc_dequeue(struct intel_engine_cs *engine)
> --
> 2.15.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-24 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 12:29 [PATCH] drm/i915/guc: Tidy ELSP port assignment Chris Wilson
2017-11-24 12:45 ` Michał Winiarski [this message]
2017-11-24 13:00 ` Chris Wilson
2017-11-24 13:09 ` Mika Kuoppala
2017-11-24 13:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-24 13:18 ` [PATCH] " Chris Wilson
2017-11-24 16:18 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124124550.7kqlahyntja45cf6@mwiniars-main.ger.corp.intel.com \
--to=michal.winiarski@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.