From: Alasdair G Kergon <agk@redhat.com>
To: "Reshetova, Elena" <elena.reshetova@intel.com>
Cc: Zdenek Kabelac <zkabelac@redhat.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"kent.overstreet@gmail.com" <kent.overstreet@gmail.com>,
"koverstreet@google.com" <koverstreet@google.com>,
"ejt@redhat.com" <ejt@redhat.com>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"shli@kernel.org" <shli@kernel.org>,
"agk@redhat.com" <agk@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"keescook@chromium.org" <keescook@chromium.org>
Subject: Re: [PATCH 4/4] dm: convert table_device.count from atomic_t to refcount_t
Date: Fri, 24 Nov 2017 14:04:13 +0000 [thread overview]
Message-ID: <20171124140413.GG5952@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B802C1F4D@IRSMSX102.ger.corp.intel.com>
On Fri, Nov 24, 2017 at 08:29:42AM +0000, Reshetova, Elena wrote:
> By looking at the code, I don't see where the change in the reference counting
> could have caused this.
The cause was the bug I identified in patch 3, not this patch.
The regression is easily hit - tables that reference the same underlying device
more than once are very common.
Alasdair
next prev parent reply other threads:[~2017-11-24 14:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 7:37 [PATCH 0/4] dm and bcache refcount conversions Elena Reshetova
2017-10-20 7:37 ` [PATCH 1/4] bcache: convert cached_dev.count from atomic_t to refcount_t Elena Reshetova
2017-10-20 18:39 ` Michael Lyle
2017-10-23 6:45 ` Reshetova, Elena
2017-10-20 7:37 ` [PATCH 2/4] dm cache: convert dm_cache_metadata.ref_count " Elena Reshetova
2017-10-20 7:37 ` [PATCH 3/4] dm: convert dm_dev_internal.count " Elena Reshetova
2017-11-23 15:49 ` [dm-devel] " Alasdair G Kergon
2017-11-24 7:36 ` Reshetova, Elena
2017-11-25 5:56 ` Mike Snitzer
2017-11-28 10:07 ` Reshetova, Elena
2017-11-28 19:02 ` Mike Snitzer
2017-11-29 8:05 ` Reshetova, Elena
2017-10-20 7:37 ` [PATCH 4/4] dm: convert table_device.count " Elena Reshetova
2017-11-23 15:19 ` Zdenek Kabelac
2017-11-24 8:29 ` Reshetova, Elena
2017-11-24 14:04 ` Alasdair G Kergon [this message]
2017-11-24 14:44 ` Reshetova, Elena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124140413.GG5952@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=elena.reshetova@intel.com \
--cc=keescook@chromium.org \
--cc=kent.overstreet@gmail.com \
--cc=koverstreet@google.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.