All of
 help / color / mirror / Atom feed
From: Tetsuo Handa <>
Subject: Re: [PATCH v2 1/2] mm,vmscan: Make unregister_shrinker() no-op if register_shrinker() failed.
Date: Fri, 24 Nov 2017 22:21:55 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Michal Hocko wrote:
> > Since we can encourage register_shrinker() callers to check for failure
> > by marking register_shrinker() as __must_check, unregister_shrinker()
> > can stay silent.
> I am not sure __must_check is the right way. We already do get
> allocation warning if the registration fails so silent unregister is
> acceptable. Unchecked register_shrinker is a bug like any other
> unchecked error path.

I consider that __must_check is the simplest way to find all of
unchecked register_shrinker bugs. Why not to encourage users to fix?

To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to  For more info on Linux MM,
see: .
Don't email: <a href=mailto:""> </a>

  reply	other threads:[~2017-11-24 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-24 11:36 [PATCH v2 1/2] mm,vmscan: Make unregister_shrinker() no-op if register_shrinker() failed Tetsuo Handa
2017-11-24 11:36 ` [PATCH v2 2/2] mm,vmscan: Mark register_shrinker() as __must_check Tetsuo Handa
2017-11-24 12:24   ` Michal Hocko
2017-11-24 13:26     ` Tetsuo Handa
2017-11-24 13:37       ` Michal Hocko
2017-11-24 12:21 ` [PATCH v2 1/2] mm,vmscan: Make unregister_shrinker() no-op if register_shrinker() failed Michal Hocko
2017-11-24 13:21   ` Tetsuo Handa [this message]
2017-11-24 13:28     ` Michal Hocko
2017-11-25  1:40       ` Tetsuo Handa
2017-11-27  8:29         ` Michal Hocko
2017-11-29 13:44           ` Tetsuo Handa
2017-11-29 13:55             ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.