All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: david@fromorbit.com, hch@infradead.org, darrick.wong@oracle.com,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xfs: handle register_shrinker error
Date: Mon, 27 Nov 2017 09:05:00 +0100	[thread overview]
Message-ID: <20171127080500.akpzasr6z6adyesk@dhcp22.suse.cz> (raw)
In-Reply-To: <201711261114.DBJ78191.SOOFOHMJLQFVFt@I-love.SAKURA.ne.jp>

On Sun 26-11-17 11:14:25, Tetsuo Handa wrote:
> Dave Chinner wrote:
> > IOWs, we don't actually need to touch this code, but if you really
> > must, just remove the KM_NOFS tag.
> 
> OK. Then, please remove KM_NOFS. GFP_KERNEL is safer than GFP_NOFS
> in the sense that it won't cause OOM lockup due to unable to invoke
> the OOM killer.

I agree that we should remove nofs request if they are not really
needed. But arguing your usual OOM lockup is (again) over exaggerating.
As a rule of thumb, it is almost always better to have the full reclaim
context rather than reduced one because the later one can influence
other parts of the system as they might need to do more work.

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2017-11-27  8:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 12:08 [PATCH] xfs: handle register_shrinker error Michal Hocko
2017-11-23 13:26 ` Christoph Hellwig
2017-11-23 13:41   ` Michal Hocko
2017-11-23 16:01     ` Tetsuo Handa
2017-11-23 16:11       ` Michal Hocko
2017-11-23 16:17         ` Tetsuo Handa
2017-11-23 16:31           ` Michal Hocko
2017-11-23 22:00         ` Dave Chinner
2017-11-24  7:39           ` [PATCH v2] " Michal Hocko
2017-11-24 12:03             ` Tetsuo Handa
2017-11-24 12:09               ` Michal Hocko
2017-11-25 23:34               ` Dave Chinner
2017-11-26  2:14                 ` Tetsuo Handa
2017-11-27  8:05                   ` Michal Hocko [this message]
2017-11-27 17:44             ` Darrick J. Wong
2017-11-28  9:35               ` Michal Hocko
2017-11-28 16:39                 ` Darrick J. Wong
2017-11-28 19:40                   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127080500.akpzasr6z6adyesk@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.