* [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A
@ 2017-11-27 9:12 Joonas Lahtinen
2017-11-27 9:43 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-11-27 9:12 UTC (permalink / raw)
To: Intel graphics driver community testing & development
Cc: Eero Tamminen, Matthew Auld, Rodrigo Vivi
We seem to be missing some W/A for 2M pages and are getting
a hit on raw GPU read bandwidths (even 30%) even though the
GPU write bandwidths improve (even 10%).
For now, disable THP, which is our only practical source of
2M pages until we have a W/A for the issue.
v2:
- Be explicit that we talk about GPU bandwidths (Eero)
- s/deny/never/ because that's why (Chris)
Reported-by: Valtteri Rantala <valtteri.rantala@intel.com>
Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Valtteri Rantala <valtteri.rantala@intel.com>
Cc: Eero Tamminen <eero.t.tamminen@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/i915_gemfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gemfs.c b/drivers/gpu/drm/i915/i915_gemfs.c
index e2993857df37..888b7d3f04c3 100644
--- a/drivers/gpu/drm/i915/i915_gemfs.c
+++ b/drivers/gpu/drm/i915/i915_gemfs.c
@@ -52,7 +52,8 @@ int i915_gemfs_init(struct drm_i915_private *i915)
if (has_transparent_hugepage()) {
struct super_block *sb = gemfs->mnt_sb;
- char options[] = "huge=within_size";
+ /* FIXME: Disabled until we get W/A for read BW issue. */
+ char options[] = "huge=never";
int flags = 0;
int err;
--
2.14.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Disable THP until we have a GPU read BW W/A
2017-11-27 9:12 [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A Joonas Lahtinen
@ 2017-11-27 9:43 ` Patchwork
2017-11-27 10:33 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-27 13:36 ` [PATCH] " Rantala, Valtteri
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-11-27 9:43 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Disable THP until we have a GPU read BW W/A
URL : https://patchwork.freedesktop.org/series/34441/
State : success
== Summary ==
Series 34441v1 drm/i915: Disable THP until we have a GPU read BW W/A
https://patchwork.freedesktop.org/api/1.0/series/34441/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:445s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:451s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:382s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:530s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:280s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:506s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:512s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:499s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:498s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:431s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:266s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:547s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:427s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:437s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:430s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:488s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:456s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:487s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:531s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:482s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:536s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:569s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:458s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:546s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:570s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:513s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:500s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:459s
fi-snb-2520m total:246 pass:212 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:419s
Blacklisted hosts:
fi-cfl-s2 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:601s
fi-cnl-y total:269 pass:242 dwarn:0 dfail:0 fail:0 skip:26
fi-glk-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:508s
2ac27dcb0eb2b64104e890031705714051be9ef8 drm-tip: 2017y-11m-26d-19h-47m-14s UTC integration manifest
c67181bf4523 drm/i915: Disable THP until we have a GPU read BW W/A
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7299/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.IGT: warning for drm/i915: Disable THP until we have a GPU read BW W/A
2017-11-27 9:12 [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A Joonas Lahtinen
2017-11-27 9:43 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-11-27 10:33 ` Patchwork
2017-11-27 13:36 ` [PATCH] " Rantala, Valtteri
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-11-27 10:33 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Disable THP until we have a GPU read BW W/A
URL : https://patchwork.freedesktop.org/series/34441/
State : warning
== Summary ==
Test kms_flip:
Subgroup flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887
Test kms_chv_cursor_fail:
Subgroup pipe-b-128x128-bottom-edge:
pass -> SKIP (shard-hsw)
Test kms_atomic:
Subgroup atomic_invalid_params:
pass -> SKIP (shard-hsw)
Subgroup crtc_invalid_params:
pass -> SKIP (shard-hsw)
Test drv_module_reload:
Subgroup basic-no-display:
pass -> DMESG-WARN (shard-hsw) fdo#102707
Test drv_selftest:
Subgroup mock_sanitycheck:
dmesg-warn -> PASS (shard-snb) fdo#103717
Test perf:
Subgroup blocking:
fail -> PASS (shard-hsw) fdo#102252
Test kms_vblank:
Subgroup query-busy:
pass -> SKIP (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
pass -> FAIL (shard-snb) fdo#101623
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#103717 https://bugs.freedesktop.org/show_bug.cgi?id=103717
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
shard-hsw total:2662 pass:1529 dwarn:2 dfail:0 fail:11 skip:1120 time:9408s
shard-snb total:2662 pass:1305 dwarn:2 dfail:0 fail:13 skip:1342 time:8130s
Blacklisted hosts:
shard-apl total:2662 pass:1690 dwarn:1 dfail:0 fail:22 skip:949 time:13475s
shard-kbl total:2662 pass:1797 dwarn:9 dfail:0 fail:25 skip:831 time:11134s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7299/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A
2017-11-27 9:12 [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A Joonas Lahtinen
2017-11-27 9:43 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-27 10:33 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-11-27 13:36 ` Rantala, Valtteri
2017-11-29 8:00 ` Joonas Lahtinen
2 siblings, 1 reply; 5+ messages in thread
From: Rantala, Valtteri @ 2017-11-27 13:36 UTC (permalink / raw)
To: Joonas Lahtinen,
Intel graphics driver community testing & development
Cc: Tamminen, Eero T, Vivi, Rodrigo, Auld, Matthew
> -----Original Message-----
> From: Joonas Lahtinen [mailto:joonas.lahtinen@linux.intel.com]
> Sent: Monday, November 27, 2017 11:13 AM
> To: Intel graphics driver community testing & development <intel-
> gfx@lists.freedesktop.org>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Auld, Matthew
> <matthew.auld@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>; Jani
> Nikula <jani.nikula@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> Rantala, Valtteri <valtteri.rantala@intel.com>; Tamminen, Eero T
> <eero.t.tamminen@intel.com>
> Subject: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A
>
> We seem to be missing some W/A for 2M pages and are getting a hit on raw
> GPU read bandwidths (even 30%) even though the GPU write bandwidths
> improve (even 10%).
>
> For now, disable THP, which is our only practical source of 2M pages until we
> have a W/A for the issue.
>
> v2:
> - Be explicit that we talk about GPU bandwidths (Eero)
> - s/deny/never/ because that's why (Chris)
>
> Reported-by: Valtteri Rantala <valtteri.rantala@intel.com>
> Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Valtteri Rantala <valtteri.rantala@intel.com>
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Tested-by: Valtteri Rantala <valtteri.rantala@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gemfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gemfs.c
> b/drivers/gpu/drm/i915/i915_gemfs.c
> index e2993857df37..888b7d3f04c3 100644
> --- a/drivers/gpu/drm/i915/i915_gemfs.c
> +++ b/drivers/gpu/drm/i915/i915_gemfs.c
> @@ -52,7 +52,8 @@ int i915_gemfs_init(struct drm_i915_private *i915)
>
> if (has_transparent_hugepage()) {
> struct super_block *sb = gemfs->mnt_sb;
> - char options[] = "huge=within_size";
> + /* FIXME: Disabled until we get W/A for read BW issue. */
> + char options[] = "huge=never";
> int flags = 0;
> int err;
>
> --
> 2.14.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A
2017-11-27 13:36 ` [PATCH] " Rantala, Valtteri
@ 2017-11-29 8:00 ` Joonas Lahtinen
0 siblings, 0 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-11-29 8:00 UTC (permalink / raw)
To: Rantala, Valtteri,
Intel graphics driver community testing & development
Cc: Tamminen, Eero T, Vivi, Rodrigo, Auld, Matthew
On Mon, 2017-11-27 at 13:36 +0000, Rantala, Valtteri wrote:
> > -----Original Message-----
> > From: Joonas Lahtinen [mailto:joonas.lahtinen@linux.intel.com]
> > Sent: Monday, November 27, 2017 11:13 AM
> > To: Intel graphics driver community testing & development <intel-
> > gfx@lists.freedesktop.org>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Auld, Matthew
> > <matthew.auld@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>; Jani
> > Nikula <jani.nikula@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> > Rantala, Valtteri <valtteri.rantala@intel.com>; Tamminen, Eero T
> > <eero.t.tamminen@intel.com>
> > Subject: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A
> >
> > We seem to be missing some W/A for 2M pages and are getting a hit on raw
> > GPU read bandwidths (even 30%) even though the GPU write bandwidths
> > improve (even 10%).
> >
> > For now, disable THP, which is our only practical source of 2M pages until we
> > have a W/A for the issue.
> >
> > v2:
> > - Be explicit that we talk about GPU bandwidths (Eero)
> > - s/deny/never/ because that's why (Chris)
> >
> > Reported-by: Valtteri Rantala <valtteri.rantala@intel.com>
> > Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Valtteri Rantala <valtteri.rantala@intel.com>
> > Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
> Tested-by: Valtteri Rantala <valtteri.rantala@intel.com>
I'm merging the patch, thanks for the report, reviews and testing!
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-29 8:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27 9:12 [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A Joonas Lahtinen
2017-11-27 9:43 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-27 10:33 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-27 13:36 ` [PATCH] " Rantala, Valtteri
2017-11-29 8:00 ` Joonas Lahtinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.