From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751397AbdK0JTW (ORCPT ); Mon, 27 Nov 2017 04:19:22 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:45012 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252AbdK0JTU (ORCPT ); Mon, 27 Nov 2017 04:19:20 -0500 X-Google-Smtp-Source: AGs4zMa3EEF+WOM52/YoVkPkVxecjpFa6SdnLaIE1j9goLZPq9+JepkBpAZGSXHdcwV+OSqLZ6FiFA== Date: Mon, 27 Nov 2017 10:19:16 +0100 From: Ingo Molnar To: Borislav Petkov Cc: Andy Lutomirski , "linux-kernel@vger.kernel.org" , Dave Hansen , Thomas Gleixner , "H . Peter Anvin" , Peter Zijlstra , Linus Torvalds Subject: Re: [PATCH 12/43] x86/espfix/64: Stop assuming that pt_regs is on the entry stack Message-ID: <20171127091916.4u4kmbqjixjwg76q@gmail.com> References: <20171124172411.19476-1-mingo@kernel.org> <20171124172411.19476-13-mingo@kernel.org> <20171124182517.s266w4ppg4csrjrn@pd.tnic> <20171126140533.d77hroi7jjvaf42g@gmail.com> <20171126172847.dxdqckearsd34kge@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171126172847.dxdqckearsd34kge@pd.tnic> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > On Sun, Nov 26, 2017 at 03:05:33PM +0100, Ingo Molnar wrote: > > > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/entry_stack&id=6510485d026abdd144d170b1bc8508327acb5648 > > > > I have added Boris's reviewed-by tag: > > > > Reviewed-by: Borislav Petkov > > > > which I suspect applies now? > > Almost, looking at the patch at that URL, there's a trailing "modify" in the > comment: > > + * we land directly at the #GP(0) vector with the stack already > + * set up according to its expectations.modify > ^^^^^^ > which you can amend-remove. Oops - fixed. > Other than that, it looks good! Thanks! Ingo