From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753690AbdK0Qve (ORCPT ); Mon, 27 Nov 2017 11:51:34 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:33540 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbdK0Qvd (ORCPT ); Mon, 27 Nov 2017 11:51:33 -0500 Date: Mon, 27 Nov 2017 08:50:44 -0800 From: "Darrick J. Wong" To: Pavel Machek Cc: Greg Kroah-Hartman , Linus Torvalds , Philippe Ombredanne , Christoph Hellwig , "Theodore Ts'o" , Alan Cox , Eric Sandeen , xfs , LKML , Kate Stewart Subject: Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license Message-ID: <20171127165044.GA19379@magnolia> References: <20171107073940.GB4654@kroah.com> <20171107172042.GB26910@magnolia> <20171107182903.GA4588@kroah.com> <20171107184658.56b87d41@alans-desktop> <20171107191526.x3rzfcnnlmaz264d@thunk.org> <20171107192846.GA24617@infradead.org> <20171122170713.GD12684@amd> <20171122175346.GB6528@kroah.com> <20171125191223.GC5114@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171125191223.GC5114@amd> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 25, 2017 at 08:12:23PM +0100, Pavel Machek wrote: > Hi! > > > > This would be even better: > > > > > > /* > > > * Driver for SMSC USB3503 USB 2.0 hub controller driver > > > * > > > * Copyright (c) 2012-2013 Dongjin Kim (tobetter@gmail.com) > > > */ > > > ... > > > SPDX_MODULE_LICENSE("GPL-2.0+") > > > > > > So yes, SPDX can be improvement. But in current implementation it is > > > not. > > > > Again, as people seem to keep still missing this point, Linus asked for > > the format to look like it does today, using // at the top. Thomas and > > I originally did it first the way with the SPDX line in the big comment > > block. > > > > If you don't like the format, complain and convince him otherwise, you > > are not getting anywhere by responding to this old topic about it > > again. > > Hey, Linus. This // SPDX at the begining of file looks really > ugly. Can we get something that looks less bad? > > And BTW I responded to this uglyness before, but you just tried to > make me shut up, and then did not reply. Given what quality you > normally expect from patch submitters, you are doing pretty poor job > here. > > > Having it be the first line of the file is good, it's obvious, and > > stands out, which is the point, you want it to, it's a license :) > > What is good about that? License is about the least interesting thing > about the file. Point of SPDX conversion (see the mail I was replying > to?) was to make license information _less_ intrusive, not more. Tools > can find SPDX anywhere in the file for the people that really care. > > That's how it works in U-Boot, which people are using as example of > reasonable SPDX conversion: > > /* > * Copyright (c) 2012 The Chromium OS Authors. All rights reserved. > * Copyright (c) 2010-2011 NVIDIA Corporation > * NVIDIA Corporation > * > * SPDX-License-Identifier: GPL-2.0+ > */ Agree. If/when anyone /does/ get to SPDX'ing the xfs files that already have a comment blob at the top, this is my preferred format for doing that. (versus having a sole //-style comment right before a multiline comment) --D > > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html