From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753572AbdK0Vrm (ORCPT ); Mon, 27 Nov 2017 16:47:42 -0500 Received: from mga04.intel.com ([192.55.52.120]:59864 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752584AbdK0Vrk (ORCPT ); Mon, 27 Nov 2017 16:47:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,465,1505804400"; d="scan'208";a="1249197894" Date: Mon, 27 Nov 2017 13:47:39 -0800 From: Solio Sarabia To: Eric Dumazet Cc: kys@microsoft.com, shiny.sebastian@intel.com, dsahern@gmail.com, davem@davemloft.net, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net-sysfs: export gso_max_size attribute Message-ID: <20171127214739.GA203@intel.com> References: <1511397041-27994-1-git-send-email-solio.sarabia@intel.com> <338121b9-5e71-be85-7faf-02dbba070df3@gmail.com> <1511548369.16595.4.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1511548369.16595.4.camel@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 24, 2017 at 10:32:49AM -0800, Eric Dumazet wrote: > On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote: > > > > This should be added to rtnetlink rather than sysfs. > > This is already exposed by rtnetlink [1] > > Please lets not add yet another net-sysfs knob. > > [1] c70ce028e834f8e51306217dbdbd441d851c64d3 net/rtnetlink: add IFLA_GSO_MAX_SEGS and IFLA_GSO_MAX_SIZE attributes It's useful `ip -d a` reports these values. Thanks. I had an old version (iproute2-ss151103). Based on changelog, it is available since iproute2-ss161009.