From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Shalini Chellathurai Saroja <shalini@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids
Date: Tue, 28 Nov 2017 10:10:10 +0800 [thread overview]
Message-ID: <20171128021010.GN5859@bjsdjshi@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171127135816.488c52cc.cohuck@redhat.com>
* Cornelia Huck <cohuck@redhat.com> [2017-11-27 13:58:16 +0100]:
> On Mon, 27 Nov 2017 10:20:56 +0800
> Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:
>
> > * Halil Pasic <pasic@linux.vnet.ibm.com> [2017-11-24 17:39:04 +0100]:
> >
> > >
> > >
> > > On 11/24/2017 05:15 PM, Cornelia Huck wrote:
> > > >>> In theory this should work.
> > > >>>
> > > >>> In reality it seems more complicated. A per-device property is easy and can be
> > > >>> inspected on the command line (e.g. -device virtio-blk-ccw,help), while a new
> > > >>> machine property would require to change the qemu help output and qemu-options
> > > >>> file (which makes it visible for all architectures).
> > > >> And then we have the fun of describing, that this property is weird, and can
> > > >> not be set, and it's value does not matter.
> > > > Well, that's the case for both, no?
> > >
> > >
> > > I don't think we have to document _device_ properites in qemu-options.hx
> > > I don't see any documented neither for virtio-ccw nor for vfio-ccw. The
> > > machine properties, on the contrary, are documented in this file.
> > Is it sane and possible to reuse the existing s390-squash-mcss property
> > to achieve the goal? I mean, when it is false (which is the default
> > value), can we treat it as "we are allowed to put devices everywhere"?
> > Then we'd have the way to use a property of the -M to tell libvirt that
> > devices can be everywhere?
> >
> > However then we can not drop it completely I guess, since Libvirt will
> > depends on it. But we can ignore the operation of setting it's value to
> > true.
>
> I don't think we should reuse it, as it would have rather confusing
> semantics (which can't be easily sorted out unless you check for the
> qemu version).
>
Right. This is something that I missed. So please ignore my noise.
--
Dong Jia Shi
next prev parent reply other threads:[~2017-11-28 2:10 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 11:18 [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids Halil Pasic
2017-11-21 13:44 ` Cornelia Huck
2017-11-21 14:27 ` Christian Borntraeger
2017-11-21 14:45 ` Christian Borntraeger
2017-11-21 16:06 ` Cornelia Huck
2017-11-21 18:10 ` Christian Borntraeger
2017-11-22 12:18 ` Cornelia Huck
2017-11-21 15:47 ` Halil Pasic
2017-11-21 16:20 ` Cornelia Huck
2017-11-21 17:05 ` Halil Pasic
2017-11-22 12:13 ` Cornelia Huck
2017-11-22 14:45 ` Boris Fiuczynski
2017-11-22 16:25 ` Cornelia Huck
2017-11-23 13:33 ` Halil Pasic
2017-11-24 12:46 ` Cornelia Huck
2017-11-24 13:01 ` Christian Borntraeger
2017-11-24 13:27 ` Cornelia Huck
2017-11-24 14:58 ` Christian Borntraeger
2017-11-24 15:30 ` Halil Pasic
2017-11-24 16:15 ` Cornelia Huck
2017-11-24 16:39 ` Halil Pasic
2017-11-27 2:20 ` Dong Jia Shi
2017-11-27 12:58 ` Cornelia Huck
2017-11-28 2:10 ` Dong Jia Shi [this message]
2017-11-27 12:56 ` Cornelia Huck
2017-11-27 13:11 ` Halil Pasic
2017-11-27 13:19 ` Cornelia Huck
2017-11-27 14:03 ` Christian Borntraeger
2017-11-27 14:38 ` Halil Pasic
2017-11-27 14:13 ` Halil Pasic
2017-11-27 15:09 ` Boris Fiuczynski
2017-11-27 16:56 ` Cornelia Huck
2017-11-27 17:34 ` Halil Pasic
2017-11-28 2:08 ` Dong Jia Shi
2017-11-28 8:53 ` Boris Fiuczynski
2017-11-28 10:22 ` Cornelia Huck
2017-11-28 11:49 ` Boris Fiuczynski
2017-11-28 12:14 ` Cornelia Huck
2017-11-28 12:24 ` Christian Borntraeger
2017-11-28 13:17 ` Halil Pasic
2017-11-28 13:25 ` Christian Borntraeger
2017-11-28 14:01 ` Cornelia Huck
2017-11-28 14:17 ` Christian Borntraeger
2017-11-28 14:45 ` Cornelia Huck
2017-11-29 18:51 ` Christian Borntraeger
2017-11-30 9:50 ` Cornelia Huck
2017-11-30 12:09 ` Christian Borntraeger
2017-11-28 14:11 ` Halil Pasic
2017-11-23 16:09 ` Halil Pasic
2017-11-23 16:59 ` Cornelia Huck
2017-11-22 11:25 ` Shalini Chellathurai Saroja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128021010.GN5859@bjsdjshi@linux.vnet.ibm.com \
--to=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=fiuczy@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=shalini@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.