All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ashish Kalra <eashishkalra@gmail.com>
To: morganfreeman6991@gmail.com
Cc: zajec5@gmail.com, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Ashish Kalra <eashishkalra@gmail.com>
Subject: [PATCH v2] drivers: bcma: driver_pcie2.c: Comment format correction & moving trailing */ to a separate line  as per checkpatch
Date: Tue, 28 Nov 2017 07:41:42 +0530	[thread overview]
Message-ID: <20171128021142.2793-1-eashishkalra@gmail.com> (raw)
In-Reply-To: <20171126172747.GA6512@himanshu-Vostro-3559>
In-Reply-To: <20171126172747.GA6512@himanshu-Vostro-3559>

This patch fixes the checkpatch.pl warning:

WARNING: Block comments use * on subsequent lines
+		/* TODO:
+		si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */

WARNING: Block comments use a trailing */ on a separate line
+		si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */

total: 0 errors, 2 warnings, 200 lines checked
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
changes from v1 (https://lkml.org/lkml/2017/11/26/85)
v2: Improved commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com>

 drivers/bcma/driver_pcie2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c
index b1a6e327cb23..cf889fc62ac7 100644
--- a/drivers/bcma/driver_pcie2.c
+++ b/drivers/bcma/driver_pcie2.c
@@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2)
 		bcma_core_pcie2_set_ltr_vals(pcie2);
 
 		/* TODO:
-		si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */
+		 *si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0);
+		 */
 
 		/* enable the LTR */
 		devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB;
-- 
2.14.1

  reply	other threads:[~2017-11-28  2:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26 16:05 [PATCH] Removed Warning shown in checkpatch.pl for comment and white space Ashish Kalra
2017-11-26 17:27 ` Morgan Freeman
2017-11-28  2:11   ` Ashish Kalra [this message]
2017-11-28  8:35     ` [PATCH v2] drivers: bcma: driver_pcie2.c: Comment format correction & moving trailing */ to a separate line as per checkpatch Morgan Freeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128021142.2793-1-eashishkalra@gmail.com \
    --to=eashishkalra@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=morganfreeman6991@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.