From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932163AbdK1Cmr (ORCPT ); Mon, 27 Nov 2017 21:42:47 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:44245 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932125AbdK1Cmo (ORCPT ); Mon, 27 Nov 2017 21:42:44 -0500 X-Google-Smtp-Source: AGs4zMbUh0NxK+zF0L9DF9Omyoud0A980bRXMrAfNwyI++rr8VZ2xi/7+9kaSt6i60vByYdZM7lVBA== Date: Tue, 28 Nov 2017 08:12:39 +0530 From: Viresh Kumar To: Arvind Yadav Cc: sboyd@codeaurora.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, ysato@users.sourceforge.jp, vz@mleia.com, slemieux.tyco@gmail.com, vireshk@kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines Message-ID: <20171128024239.GD11413@vireshk-i7> References: <35a712ed8ee10491c0a605d0cc825250286370a4.1511505932.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35a712ed8ee10491c0a605d0cc825250286370a4.1511505932.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24-11-17, 12:25, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav > --- > drivers/clk/spear/clk-gpt-synth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/spear/clk-gpt-synth.c b/drivers/clk/spear/clk-gpt-synth.c > index 1a722e9..1cf219a6 100644 > --- a/drivers/clk/spear/clk-gpt-synth.c > +++ b/drivers/clk/spear/clk-gpt-synth.c > @@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char *parent_name, unsigned > struct clk *clk; > > if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) { > - pr_err("Invalid arguments passed"); > + pr_err("Invalid arguments passed\n"); > return ERR_PTR(-EINVAL); > } Acked-by: Viresh Kumar -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Tue, 28 Nov 2017 08:12:39 +0530 Subject: [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines In-Reply-To: <35a712ed8ee10491c0a605d0cc825250286370a4.1511505932.git.arvind.yadav.cs@gmail.com> References: <35a712ed8ee10491c0a605d0cc825250286370a4.1511505932.git.arvind.yadav.cs@gmail.com> Message-ID: <20171128024239.GD11413@vireshk-i7> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 24-11-17, 12:25, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav > --- > drivers/clk/spear/clk-gpt-synth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/spear/clk-gpt-synth.c b/drivers/clk/spear/clk-gpt-synth.c > index 1a722e9..1cf219a6 100644 > --- a/drivers/clk/spear/clk-gpt-synth.c > +++ b/drivers/clk/spear/clk-gpt-synth.c > @@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char *parent_name, unsigned > struct clk *clk; > > if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) { > - pr_err("Invalid arguments passed"); > + pr_err("Invalid arguments passed\n"); > return ERR_PTR(-EINVAL); > } Acked-by: Viresh Kumar -- viresh