From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472AbdK1RFl (ORCPT ); Tue, 28 Nov 2017 12:05:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:37010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751144AbdK1RFk (ORCPT ); Tue, 28 Nov 2017 12:05:40 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 821BD21894 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 28 Nov 2017 12:05:37 -0500 From: Steven Rostedt To: "Vladislav Valtchev (VMware)" Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com Subject: Re: [PATCH 05/11] trace-cmd: Rename trace_profile() to trace_profile_int() Message-ID: <20171128120537.04cf379a@gandalf.local.home> In-Reply-To: <20171123163335.19078-6-vladislav.valtchev@gmail.com> References: <20171123163335.19078-1-vladislav.valtchev@gmail.com> <20171123163335.19078-6-vladislav.valtchev@gmail.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Nov 2017 18:33:29 +0200 "Vladislav Valtchev (VMware)" wrote: > The purpose of this renaming is to make room for a new trace_profile() function, > that will handle directly the 'profile' command, following the internal > convention COMMAND_NAME -> trace_{COMMAND_NAME}. Couple of things. 1) A change like this should always be directly before the patch that requires it. This is patch 5, and it's not until patch 8 that this change is required. Please keep them next to each other. This should have been patch 7. 2) trace_profile_int() is confusing. I keep thinking it's doing something with integers. Call it do_trace_profile(). Thanks! -- Steve