* [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues
@ 2017-11-14 20:03 Chase Metzger
2017-11-28 13:01 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Chase Metzger @ 2017-11-14 20:03 UTC (permalink / raw)
To: gregkh
Cc: Chase Metzger, Marcus Wolf, Joseph Wright, Colin Ian King,
Haneen Mohammed, Elia Geretto, Srishti Sharma, Xiangyang Zhang,
Derek Robson, Cihangir Akturk, devel, linux-kernel
Fix if/else if and braces in function DIO0_irq_handler to comply with
the kernel coding style.
Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index d946838450d4..dee70c47629c 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -133,19 +133,14 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
{
struct pi433_device *device = dev_id;
- if (device->irq_state[DIO0] == DIO_PacketSent)
- {
+ if (device->irq_state[DIO0] == DIO_PacketSent) {
device->free_in_fifo = FIFO_SIZE;
dev_dbg(device->dev, "DIO0 irq: Packet sent\n");
wake_up_interruptible(&device->fifo_wait_queue);
- }
- else if (device->irq_state[DIO0] == DIO_Rssi_DIO0)
- {
+ } else if (device->irq_state[DIO0] == DIO_Rssi_DIO0) {
dev_dbg(device->dev, "DIO0 irq: RSSI level over threshold\n");
wake_up_interruptible(&device->rx_wait_queue);
- }
- else if (device->irq_state[DIO0] == DIO_PayloadReady)
- {
+ } else if (device->irq_state[DIO0] == DIO_PayloadReady) {
dev_dbg(device->dev, "DIO0 irq: PayloadReady\n");
device->free_in_fifo = 0;
wake_up_interruptible(&device->fifo_wait_queue);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues
2017-11-14 20:03 [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues Chase Metzger
@ 2017-11-28 13:01 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-11-28 13:01 UTC (permalink / raw)
To: Chase Metzger
Cc: Marcus Wolf, Joseph Wright, Colin Ian King, Haneen Mohammed,
Elia Geretto, Srishti Sharma, Xiangyang Zhang, Derek Robson,
Cihangir Akturk, devel, linux-kernel
On Tue, Nov 14, 2017 at 12:03:51PM -0800, Chase Metzger wrote:
> Fix if/else if and braces in function DIO0_irq_handler to comply with
> the kernel coding style.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d946838450d4..dee70c47629c 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -133,19 +133,14 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
> {
> struct pi433_device *device = dev_id;
>
> - if (device->irq_state[DIO0] == DIO_PacketSent)
> - {
> + if (device->irq_state[DIO0] == DIO_PacketSent) {
When you are touching the line, be sure to fix the obvious space issue
here as well.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-28 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-14 20:03 [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues Chase Metzger
2017-11-28 13:01 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.