From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbdK1QSm (ORCPT ); Tue, 28 Nov 2017 11:18:42 -0500 Received: from muru.com ([72.249.23.125]:52464 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbdK1QSk (ORCPT ); Tue, 28 Nov 2017 11:18:40 -0500 Date: Tue, 28 Nov 2017 08:18:34 -0800 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string Message-ID: <20171128161834.GE28152@atomide.com> References: <20171128160437.GD28152@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Nikolaus Schaller [171128 16:17]: > Hi Tony, > > > Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 15:52]: > >> We can remove the unnecessary "omapdss," prefix because > >> the omapdrm driver takes care of it when matching with > >> the driver table. > > > > So is this needed as a fix or is this another clean-up? > > > > So is this is really needed as a fix? > > Hm. How do you differentiate between "fix" and "cleanup"? > Maybe it is more a wording than a content issue... > > For me it is a "fix" because it is semantically wrong to have > a prefix where it is not needed. And "fixing" it changes the > compiler output by 8 bytes. How about let's call it a "typo fix" then? :) > "Cleanup" would be for me removing whitespace or empty lines > or typos in comments. > > > If this is just clean-up, again, please resend once the driver > > changes have cleared. > > There is no change to the pandora driver involved here. The Pandora > panel driver is already correct. Just the DTS has some redundant > content which should be removed. > > So there is no dependency for this patch. OK please resend separately after the driver changes have merged then. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string Date: Tue, 28 Nov 2017 08:18:34 -0800 Message-ID: <20171128161834.GE28152@atomide.com> References: <20171128160437.GD28152@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "H. Nikolaus Schaller" Cc: Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, letux-kernel-S0jZdbWzriLCfDggNXIi3w@public.gmane.org, kernel-Jl6IXVxNIMRxAtABVqVhTwC/G2K4zDHf@public.gmane.org List-Id: devicetree@vger.kernel.org * H. Nikolaus Schaller [171128 16:17]: > Hi Tony, > > > Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 15:52]: > >> We can remove the unnecessary "omapdss," prefix because > >> the omapdrm driver takes care of it when matching with > >> the driver table. > > > > So is this needed as a fix or is this another clean-up? > > > > So is this is really needed as a fix? > > Hm. How do you differentiate between "fix" and "cleanup"? > Maybe it is more a wording than a content issue... > > For me it is a "fix" because it is semantically wrong to have > a prefix where it is not needed. And "fixing" it changes the > compiler output by 8 bytes. How about let's call it a "typo fix" then? :) > "Cleanup" would be for me removing whitespace or empty lines > or typos in comments. > > > If this is just clean-up, again, please resend once the driver > > changes have cleared. > > There is no change to the pandora driver involved here. The Pandora > panel driver is already correct. Just the DTS has some redundant > content which should be removed. > > So there is no dependency for this patch. OK please resend separately after the driver changes have merged then. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Tue, 28 Nov 2017 16:18:34 +0000 Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string Message-Id: <20171128161834.GE28152@atomide.com> List-Id: References: <20171128160437.GD28152@atomide.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "H. Nikolaus Schaller" Cc: Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, letux-kernel-S0jZdbWzriLCfDggNXIi3w@public.gmane.org, kernel-Jl6IXVxNIMRxAtABVqVhTwC/G2K4zDHf@public.gmane.org * H. Nikolaus Schaller [171128 16:17]: > Hi Tony, > > > Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 15:52]: > >> We can remove the unnecessary "omapdss," prefix because > >> the omapdrm driver takes care of it when matching with > >> the driver table. > > > > So is this needed as a fix or is this another clean-up? > > > > So is this is really needed as a fix? > > Hm. How do you differentiate between "fix" and "cleanup"? > Maybe it is more a wording than a content issue... > > For me it is a "fix" because it is semantically wrong to have > a prefix where it is not needed. And "fixing" it changes the > compiler output by 8 bytes. How about let's call it a "typo fix" then? :) > "Cleanup" would be for me removing whitespace or empty lines > or typos in comments. > > > If this is just clean-up, again, please resend once the driver > > changes have cleared. > > There is no change to the pandora driver involved here. The Pandora > panel driver is already correct. Just the DTS has some redundant > content which should be removed. > > So there is no dependency for this patch. OK please resend separately after the driver changes have merged then. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 28 Nov 2017 08:18:34 -0800 Subject: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string In-Reply-To: References: <20171128160437.GD28152@atomide.com> Message-ID: <20171128161834.GE28152@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * H. Nikolaus Schaller [171128 16:17]: > Hi Tony, > > > Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 15:52]: > >> We can remove the unnecessary "omapdss," prefix because > >> the omapdrm driver takes care of it when matching with > >> the driver table. > > > > So is this needed as a fix or is this another clean-up? > > > > So is this is really needed as a fix? > > Hm. How do you differentiate between "fix" and "cleanup"? > Maybe it is more a wording than a content issue... > > For me it is a "fix" because it is semantically wrong to have > a prefix where it is not needed. And "fixing" it changes the > compiler output by 8 bytes. How about let's call it a "typo fix" then? :) > "Cleanup" would be for me removing whitespace or empty lines > or typos in comments. > > > If this is just clean-up, again, please resend once the driver > > changes have cleared. > > There is no change to the pandora driver involved here. The Pandora > panel driver is already correct. Just the DTS has some redundant > content which should be removed. > > So there is no dependency for this patch. OK please resend separately after the driver changes have merged then. Regards, Tony