From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, oss-drivers@netronome.com,
daniel@iogearbox.net, alexei.starovoitov@gmail.com,
Sabrina Dubroca <sd@queasysnail.net>, Phil Sutter <phil@nwl.cc>
Subject: Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads
Date: Tue, 28 Nov 2017 17:20:41 +0100 [thread overview]
Message-ID: <20171128162041.GE1971@nanopsycho.orion> (raw)
In-Reply-To: <20171127114249.111b1825@cakuba.netronome.com>
Mon, Nov 27, 2017 at 08:42:49PM CET, jakub.kicinski@netronome.com wrote:
>On Tue, 28 Nov 2017 04:30:26 +0900 (KST), David Miller wrote:
>> From: Jakub Kicinski <jakub.kicinski@netronome.com>
>> Date: Thu, 23 Nov 2017 18:36:11 -0800
>>
>> > The dummy driver have previously been extended to test SR-IOV,
>> > but the general consensus seems to be against adding further
>> > features to it.
>>
>> I guess this is fine, but then is it going to be the case that
>> every time we want to add a software offload implementation for
>> testing driver paths we add yet another dummy driver?
>
>I would expect others to extend the netdevsim driver, so all test/SW
>implementation would live there.
>
>I was considering moving the SR-IOV code over, too, but I'm worried
Agreed. Leave dummy be dummy. netdevsim should serve this purpose.
Thanks!
>I will break existing tests. Phil, Sabrina would you be OK with that?
next prev parent reply other threads:[~2017-11-28 16:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 2:36 [RFC net-next 0/6] xdp: make stack perform remove and tests Jakub Kicinski
2017-11-24 2:36 ` [RFC net-next 1/6] net: xdp: avoid output parameters when querying XDP prog Jakub Kicinski
2017-11-24 2:36 ` [RFC net-next 2/6] net: xdp: report flags program was installed with on query Jakub Kicinski
2017-11-24 2:36 ` [RFC net-next 3/6] net: xdp: make the stack take care of the tear down Jakub Kicinski
2017-11-24 23:24 ` Daniel Borkmann
2017-11-25 3:28 ` Jakub Kicinski
2017-11-24 2:36 ` [RFC net-next 4/6] netdevsim: add software driver for testing offloads Jakub Kicinski
2017-11-24 7:24 ` Jiri Pirko
2017-11-24 7:49 ` Jakub Kicinski
2017-11-24 8:07 ` Jiri Pirko
2017-11-27 19:30 ` David Miller
2017-11-27 19:42 ` Jakub Kicinski
2017-11-28 14:55 ` Phil Sutter
2017-11-28 16:20 ` Jiri Pirko [this message]
2017-11-24 2:36 ` [RFC net-next 5/6] netdevsim: add bpf offload support Jakub Kicinski
2017-11-24 2:36 ` [RFC net-next 6/6] selftests/bpf: add offload test based on netdevsim Jakub Kicinski
2017-11-24 7:45 ` [RFC net-next 0/6] xdp: make stack perform remove and tests Jiri Pirko
2017-11-24 8:02 ` Jakub Kicinski
2017-11-25 4:55 ` Jakub Kicinski
2017-11-26 1:02 ` Alexei Starovoitov
2017-11-26 1:43 ` Jakub Kicinski
2017-11-26 7:43 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128162041.GE1971@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=phil@nwl.cc \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.