From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbdK2FcU (ORCPT ); Wed, 29 Nov 2017 00:32:20 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:46798 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbdK2FcS (ORCPT ); Wed, 29 Nov 2017 00:32:18 -0500 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: iamjoonsoo.kim@lge.com X-Original-SENDERIP: 10.177.222.138 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Wed, 29 Nov 2017 14:38:17 +0900 From: Joonsoo Kim To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Michal Nazarewicz , Michal Hocko , Mel Gorman , Johannes Weiner , Andrew Morton , stable@vger.kernel.org Subject: Re: [PATCH v2] mm/cma: fix alloc_contig_range ret code/potential leak Message-ID: <20171129053817.GB8125@js1304-P5Q-DELUXE> References: <15cf0f39-43f9-8287-fcfe-f2502af59e8a@oracle.com> <20171122185214.25285-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171122185214.25285-1-mike.kravetz@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 22, 2017 at 10:52:14AM -0800, Mike Kravetz wrote: > If the call __alloc_contig_migrate_range() in alloc_contig_range > returns -EBUSY, processing continues so that test_pages_isolated() > is called where there is a tracepoint to identify the busy pages. > However, it is possible for busy pages to become available between > the calls to these two routines. In this case, the range of pages > may be allocated. Unfortunately, the original return code (ret > == -EBUSY) is still set and returned to the caller. Therefore, > the caller believes the pages were not allocated and they are leaked. > > Update comment to indicate that allocation is still possible even if > __alloc_contig_migrate_range returns -EBUSY. Also, clear return code > in this case so that it is not accidentally used or returned to caller. > > Fixes: 8ef5849fa8a2 ("mm/cma: always check which page caused allocation failure") > Cc: > Signed-off-by: Mike Kravetz Good catch!! Acked-by: Joonsoo Kim Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 29 Nov 2017 14:38:17 +0900 From: Joonsoo Kim To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Michal Nazarewicz , Michal Hocko , Mel Gorman , Johannes Weiner , Andrew Morton , stable@vger.kernel.org Subject: Re: [PATCH v2] mm/cma: fix alloc_contig_range ret code/potential leak Message-ID: <20171129053817.GB8125@js1304-P5Q-DELUXE> References: <15cf0f39-43f9-8287-fcfe-f2502af59e8a@oracle.com> <20171122185214.25285-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171122185214.25285-1-mike.kravetz@oracle.com> Sender: owner-linux-mm@kvack.org List-ID: On Wed, Nov 22, 2017 at 10:52:14AM -0800, Mike Kravetz wrote: > If the call __alloc_contig_migrate_range() in alloc_contig_range > returns -EBUSY, processing continues so that test_pages_isolated() > is called where there is a tracepoint to identify the busy pages. > However, it is possible for busy pages to become available between > the calls to these two routines. In this case, the range of pages > may be allocated. Unfortunately, the original return code (ret > == -EBUSY) is still set and returned to the caller. Therefore, > the caller believes the pages were not allocated and they are leaked. > > Update comment to indicate that allocation is still possible even if > __alloc_contig_migrate_range returns -EBUSY. Also, clear return code > in this case so that it is not accidentally used or returned to caller. > > Fixes: 8ef5849fa8a2 ("mm/cma: always check which page caused allocation failure") > Cc: > Signed-off-by: Mike Kravetz Good catch!! Acked-by: Joonsoo Kim Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org