From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, Julien Grall <julien.grall@linaro.org>,
andre.przywara@linaro.org
Subject: [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells
Date: Wed, 29 Nov 2017 17:57:32 +0000 [thread overview]
Message-ID: <20171129175732.7256-1-julien.grall@linaro.org> (raw)
Per the device-tree specific [1], when the property #address-cells
and #size-cells are not present, the default value should be resp. 1
and 2.
[1] https://www.devicetree.org/downloads/devicetree-specification-v0.1-20160524.pdf
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
This was discovered debugging DT generated by GRUB on ACPI-only
platform. I am not aware of any DT relying on that for now, but it
would still be nice to be compliant with the spec and avoid
surprise.
---
xen/arch/arm/bootfdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index 4a687e725d..8eba42c7b9 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -109,8 +109,8 @@ int __init device_tree_for_each_node(const void *fdt,
continue;
}
- as = depth > 0 ? address_cells[depth-1] : 0;
- ss = depth > 0 ? size_cells[depth-1] : 0;
+ as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
+ ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
address_cells[depth] = device_tree_get_u32(fdt, node,
"#address-cells", as);
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2017-11-29 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 17:57 Julien Grall [this message]
2017-11-29 18:12 ` [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells Stefano Stabellini
2017-12-08 15:18 ` Julien Grall
2017-12-08 21:18 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129175732.7256-1-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=andre.przywara@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.