From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdK3OUo (ORCPT ); Thu, 30 Nov 2017 09:20:44 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:51439 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdK3OUk (ORCPT ); Thu, 30 Nov 2017 09:20:40 -0500 From: Christoph Hellwig To: Ingo Molnar , eter Zijlstra Cc: Andrew Morton , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] sched/wait: assert the wait_queue_head lock is held in __wake_up_common Date: Thu, 30 Nov 2017 06:20:36 -0800 Message-Id: <20171130142037.19339-2-hch@lst.de> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171130142037.19339-1-hch@lst.de> References: <20171130142037.19339-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Better ensure we actually hold the lock using lockdep than just commenting on it. Due to the various exported _locked interfaces it is far too easy to get the locking wrong. Signed-off-by: Christoph Hellwig --- kernel/sched/wait.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c index 98feab7933c7..347c06c8222e 100644 --- a/kernel/sched/wait.c +++ b/kernel/sched/wait.c @@ -76,6 +76,8 @@ static int __wake_up_common(struct wait_queue_head *wq_head, unsigned int mode, wait_queue_entry_t *curr, *next; int cnt = 0; + lockdep_assert_held(&wq_head->lock); + if (bookmark && (bookmark->flags & WQ_FLAG_BOOKMARK)) { curr = list_next_entry(bookmark, entry); -- 2.14.2