From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbdK3PYh (ORCPT ); Thu, 30 Nov 2017 10:24:37 -0500 Received: from muru.com ([72.249.23.125]:52696 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbdK3PYf (ORCPT ); Thu, 30 Nov 2017 10:24:35 -0500 Date: Thu, 30 Nov 2017 07:24:30 -0800 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Tomi Valkeinen , Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, DTML , Linux Kernel Mailing List , linux-omap , Linux ARM , linux-fbdev@vger.kernel.org, Discussions about the Letux Kernel , kernel@pyra-handheld.com Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string Message-ID: <20171130152430.GM28152@atomide.com> References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Nikolaus Schaller [171128 18:35]: > Hi, > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 16:17]: > >> Hi Tony, > >> > >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > >>> > >>> * H. Nikolaus Schaller [171128 15:52]: > >>>> We can remove the unnecessary "omapdss," prefix because > >>>> the omapdrm driver takes care of it when matching with > >>>> the driver table. > >>> > >>> So is this needed as a fix or is this another clean-up? > >>> > >>> So is this is really needed as a fix? > >> > >> Hm. How do you differentiate between "fix" and "cleanup"? > >> Maybe it is more a wording than a content issue... > >> > >> For me it is a "fix" because it is semantically wrong to have > >> a prefix where it is not needed. And "fixing" it changes the > >> compiler output by 8 bytes. > > > > How about let's call it a "typo fix" then? :) > > Well, it is not really a typo. Well what if the stable people pick it into earlier stable series based on the word fix in the subject? That has happened before. I suggest you update the dts patches to use wording like "update compatible to use new naming" or something similar. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string Date: Thu, 30 Nov 2017 07:24:30 -0800 Message-ID: <20171130152430.GM28152@atomide.com> References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" Cc: Tomi Valkeinen , Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, DTML , Linux Kernel Mailing List , linux-omap , Linux ARM , linux-fbdev@vger.kernel.org, Discussions about the Letux Kernel List-Id: devicetree@vger.kernel.org * H. Nikolaus Schaller [171128 18:35]: > Hi, > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 16:17]: > >> Hi Tony, > >> > >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > >>> > >>> * H. Nikolaus Schaller [171128 15:52]: > >>>> We can remove the unnecessary "omapdss," prefix because > >>>> the omapdrm driver takes care of it when matching with > >>>> the driver table. > >>> > >>> So is this needed as a fix or is this another clean-up? > >>> > >>> So is this is really needed as a fix? > >> > >> Hm. How do you differentiate between "fix" and "cleanup"? > >> Maybe it is more a wording than a content issue... > >> > >> For me it is a "fix" because it is semantically wrong to have > >> a prefix where it is not needed. And "fixing" it changes the > >> compiler output by 8 bytes. > > > > How about let's call it a "typo fix" then? :) > > Well, it is not really a typo. Well what if the stable people pick it into earlier stable series based on the word fix in the subject? That has happened before. I suggest you update the dts patches to use wording like "update compatible to use new naming" or something similar. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Thu, 30 Nov 2017 15:24:30 +0000 Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string Message-Id: <20171130152430.GM28152@atomide.com> List-Id: References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> In-Reply-To: <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "H. Nikolaus Schaller" Cc: Tomi Valkeinen , Thierry Reding , David Airlie , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, DTML , Linux Kernel Mailing List , linux-omap , Linux ARM , linux-fbdev@vger.kernel.org, Discussions about the Letux Kernel * H. Nikolaus Schaller [171128 18:35]: > Hi, > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 16:17]: > >> Hi Tony, > >> > >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > >>> > >>> * H. Nikolaus Schaller [171128 15:52]: > >>>> We can remove the unnecessary "omapdss," prefix because > >>>> the omapdrm driver takes care of it when matching with > >>>> the driver table. > >>> > >>> So is this needed as a fix or is this another clean-up? > >>> > >>> So is this is really needed as a fix? > >> > >> Hm. How do you differentiate between "fix" and "cleanup"? > >> Maybe it is more a wording than a content issue... > >> > >> For me it is a "fix" because it is semantically wrong to have > >> a prefix where it is not needed. And "fixing" it changes the > >> compiler output by 8 bytes. > > > > How about let's call it a "typo fix" then? :) > > Well, it is not really a typo. Well what if the stable people pick it into earlier stable series based on the word fix in the subject? That has happened before. I suggest you update the dts patches to use wording like "update compatible to use new naming" or something similar. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 30 Nov 2017 07:24:30 -0800 Subject: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string In-Reply-To: <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> References: <20171128160437.GD28152@atomide.com> <20171128161834.GE28152@atomide.com> <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com> Message-ID: <20171130152430.GM28152@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * H. Nikolaus Schaller [171128 18:35]: > Hi, > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 16:17]: > >> Hi Tony, > >> > >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > >>> > >>> * H. Nikolaus Schaller [171128 15:52]: > >>>> We can remove the unnecessary "omapdss," prefix because > >>>> the omapdrm driver takes care of it when matching with > >>>> the driver table. > >>> > >>> So is this needed as a fix or is this another clean-up? > >>> > >>> So is this is really needed as a fix? > >> > >> Hm. How do you differentiate between "fix" and "cleanup"? > >> Maybe it is more a wording than a content issue... > >> > >> For me it is a "fix" because it is semantically wrong to have > >> a prefix where it is not needed. And "fixing" it changes the > >> compiler output by 8 bytes. > > > > How about let's call it a "typo fix" then? :) > > Well, it is not really a typo. Well what if the stable people pick it into earlier stable series based on the word fix in the subject? That has happened before. I suggest you update the dts patches to use wording like "update compatible to use new naming" or something similar. Regards, Tony