Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches

From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org,
	Andy Lutomirski <luto@amacapital.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H . Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches
Date: Thu, 30 Nov 2017 17:18:44 +0100	[thread overview]
Message-ID: <20171130161844.v7ynfdggo6g7j5l5@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <3ca0bea7-932a-6d91-a9b4-d07045d444f5@linux.intel.com>

On Thu, Nov 30, 2017 at 07:51:17AM -0800, Dave Hansen wrote:
> On 11/30/2017 07:44 AM, Peter Zijlstra wrote:
> > On Mon, Nov 27, 2017 at 11:49:14AM +0100, Ingo Molnar wrote:
> >> @@ -338,24 +366,23 @@ static inline void __native_flush_tlb_single(unsigned long addr)
> >>  
> >>  static inline void __flush_tlb_all(void)
> >>  {
> >> +	if (boot_cpu_has(X86_FEATURE_PGE)) {
> >>  		__flush_tlb_global();
> >> +	} else {
> >>  		__flush_tlb();
> >> +		tlb_flush_shared_nonglobals();
> > I do however think this one is superfluous; if we do not have PGE we
> > also do not have PCID and every CR3 switch flushes everything.
> 
> I tried to sprinkle these around at all the sites that did non-global
> kernel flushes.  In the case that it's superfluous !KAISER, it's a noop
> anyway.  In the (currently unsupported) case that we *do* need it, well,
> we need it.

I'm confused. When would we need it there?