All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/microcode/AMD: Add support for fam17h microcode loading
Date: Thu, 30 Nov 2017 23:52:00 +0100	[thread overview]
Message-ID: <20171130225200.yofkwrzogbpssswr@pd.tnic> (raw)
In-Reply-To: <20171130224640.15391.40247.stgit@tlendack-t1.amdoffice.net>

On Thu, Nov 30, 2017 at 04:46:40PM -0600, Tom Lendacky wrote:
> The size for the Microcode Patch Block (MPB) for an AMD family 17h
> processor is 3200 bytes.  Add a #define for fam17h so that it does
> not default to 2048 bytes and fail a microcode load/update.
> 
> Cc: <stable@vger.kernel.org> # 4.1.x
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  arch/x86/kernel/cpu/microcode/amd.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
> index c6daec4..330b846 100644
> --- a/arch/x86/kernel/cpu/microcode/amd.c
> +++ b/arch/x86/kernel/cpu/microcode/amd.c
> @@ -470,6 +470,7 @@ static unsigned int verify_patch_size(u8 family, u32 patch_size,
>  #define F14H_MPB_MAX_SIZE 1824
>  #define F15H_MPB_MAX_SIZE 4096
>  #define F16H_MPB_MAX_SIZE 3458
> +#define F17H_MPB_MAX_SIZE 3200
>  
>  	switch (family) {
>  	case 0x14:
> @@ -481,6 +482,9 @@ static unsigned int verify_patch_size(u8 family, u32 patch_size,
>  	case 0x16:
>  		max_size = F16H_MPB_MAX_SIZE;
>  		break;
> +	case 0x17:
> +		max_size = F17H_MPB_MAX_SIZE;
> +		break;
>  	default:
>  		max_size = F1XH_MPB_MAX_SIZE;
>  		break;

Reviewed-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2017-11-30 22:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 22:46 [PATCH] x86/microcode/AMD: Add support for fam17h microcode loading Tom Lendacky
2017-11-30 22:52 ` Borislav Petkov [this message]
2017-12-04 22:09 ` [tip:x86/urgent] " tip-bot for Tom Lendacky
2017-12-06 11:35 ` tip-bot for Tom Lendacky
2017-12-10 20:20 ` [PATCH] " Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130225200.yofkwrzogbpssswr@pd.tnic \
    --to=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.