From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8 Date: Sat, 2 Dec 2017 10:22:58 +0200 Message-ID: <20171202082258.GE8126@mtr-leonro.local> References: <20171201110451.25392-1-leon@kernel.org> <20171201084807.0ccfcc86@xeon-e3> <20171201195624.udh62qoeezydnlah@unicorn.suse.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T7mxYSe680VjQnyC" Cc: Stephen Hemminger , netdev@vger.kernel.org, Riad Abo Raed , Guy Ergas To: Michal Kubecek Return-path: Received: from mail.kernel.org ([198.145.29.99]:43212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbdLBIXD (ORCPT ); Sat, 2 Dec 2017 03:23:03 -0500 Content-Disposition: inline In-Reply-To: <20171201195624.udh62qoeezydnlah@unicorn.suse.cz> Sender: netdev-owner@vger.kernel.org List-ID: --T7mxYSe680VjQnyC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 01, 2017 at 08:56:24PM +0100, Michal Kubecek wrote: > On Fri, Dec 01, 2017 at 08:48:07AM -0800, Stephen Hemminger wrote: > > On Fri, 1 Dec 2017 13:04:51 +0200 > > Leon Romanovsky wrote: > > > > > From: Leon Romanovsky > > > > > > Add asm/posix_types.h header file to the list of needed includes, > > > because the headers files in RHEL 6.8 are too old and doesn't > > > have declaration of __kernel_long_t. > > > > > > In file included from ../include/uapi/linux/kernel.h:5, > > > from ../include/uapi/linux/netfilter/x_tables.h:4, > > > from ../include/xtables.h:20, > > > from em_ipset.c:26: > > > ../include/uapi/linux/sysinfo.h:9: error: expected specifier-qualifie= r-list before =E2=80=98__kernel_long_t=E2=80=99 > > > > > > Cc: Riad Abo Raed > > > Cc: Guy Ergas > > > Signed-off-by: Leon Romanovsky > > > > I see the problem, but the solution of dragging in posix_types.h > > would be too much of a long term maintenance issue. > > All the headers in uapi are regularly generated from upstream > > kernel headers; I don't want to start making exceptions. > > > > Is it just the xtables stuff (which has always been problematic)? > > Actually, the only place where __kernel_long_t and __kernel_ulong_t > appear is struct sysinfo in include/uapi/linux/sysinfo.h and this > structure isn't even used anywhere in iproute2 source (not even in the > include/uapi/linux/kernel.h file which includes ). > > So one could work around the problem by defining _LINUX_SYSINFO_H but > that seems a bit dirty hack. It is too dirty :). It can cause to completely unpredictable compilation failures in the future, which won't be easy to track down. > > Michal Kubecek > --T7mxYSe680VjQnyC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAloiYuEACgkQ5GN7iDZy WKdOMRAAi+GT/HWGjrX2H49DpCDVDOb6lbcB/ONMm7nBZLdnee58T0cyWfQpXFDQ k150jzPLu7iSKW7k67Zq0arDtbH/nh3w0rAVJME8zZDqLcwpdJX20hEfEBXStXd6 xwnpovdkRXEeT5o78lgBgGeRhrFDtB83iRR1e2wLTCBB3x54I8AaiV+22APWPvLG CNn/1tB72M4EmqT3nazR99CiRm6dYDOEaL7qe5zDwqq+ueBtOSY/5+18zGKNjvv7 1vNRkja0fPYJ96f31eayWs8O/kbJ4GhLsQjUy9tdJyIMmDMQ0X6fICD7EVWidACl 0d57C/LJmeGHSEKqL2DjVEggmP7hUCNYqMVTA+P78GMvKQi7j0JvZchThZ3ERmLF RK9n5jJgO68QkZZGa3TtcUzWkPfcw/athkOt8sNOXsFza4homf1bKjXLnwicsR16 XjYc0DGkfdrIHxIFKkgoS1AzXrI/T29yP0AcxPTrVx37vuRIe4jPkjR9JsaNxQoT RuMMViajcpDjoNrp2Ymwtf5B87JXj2PBb+1eV6gHH8c7tAGZF0q+TElRCLq8gMlg WJQdj6Th1GRUNP/jdIfekSzTceY8Z57WwYLlPeAD3a9jhXpvywTNtWVH8xRDByVL jZzwjJyToORX98nkAyKFv5n+HOPLYecNyGzE/SlKldsdW/LgZo4= =Zm3T -----END PGP SIGNATURE----- --T7mxYSe680VjQnyC--