From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbdLCRGm (ORCPT ); Sun, 3 Dec 2017 12:06:42 -0500 Received: from mga14.intel.com ([192.55.52.115]:28479 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbdLCRGj (ORCPT ); Sun, 3 Dec 2017 12:06:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,354,1508828400"; d="scan'208";a="1251377364" Date: Sun, 3 Dec 2017 22:40:14 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: Greg Kroah-Hartman , LKML , ALSA , Mark , Takashi , patches.audio@intel.com, alan@linux.intel.com, Charles Keepax , Sagar Dharia , srinivas.kandagatla@linaro.org, plai@codeaurora.org, Sudheer Papothi Subject: Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support Message-ID: <20171203171013.GP32417@localhost> References: <1512122177-2889-1-git-send-email-vinod.koul@intel.com> <1512122177-2889-13-git-send-email-vinod.koul@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2017 at 06:02:24PM -0600, Pierre-Louis Bossart wrote: > > > struct sdw_cdns { > > struct device *dev; > > struct sdw_bus bus; > > unsigned int instance; > >+ u32 response_buf[0x80]; > > last nit-pick: use a #define for the size. okay last one huh :) yeah will add. > Also are you sure about the value? I vaguely recall that the FIFO was > 32-deep, you are confusing bytes and words here? I dont think this is related to FIFO depth, this is buffer to hold values. Will check though.. -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support Date: Sun, 3 Dec 2017 22:40:14 +0530 Message-ID: <20171203171013.GP32417@localhost> References: <1512122177-2889-1-git-send-email-vinod.koul@intel.com> <1512122177-2889-13-git-send-email-vinod.koul@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by alsa0.perex.cz (Postfix) with ESMTP id 30421266B0F for ; Sun, 3 Dec 2017 18:06:40 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: ALSA , Charles Keepax , Sudheer Papothi , Takashi , Greg Kroah-Hartman , plai@codeaurora.org, LKML , patches.audio@intel.com, Mark , srinivas.kandagatla@linaro.org, Sagar Dharia , alan@linux.intel.com List-Id: alsa-devel@alsa-project.org On Fri, Dec 01, 2017 at 06:02:24PM -0600, Pierre-Louis Bossart wrote: > > > struct sdw_cdns { > > struct device *dev; > > struct sdw_bus bus; > > unsigned int instance; > >+ u32 response_buf[0x80]; > > last nit-pick: use a #define for the size. okay last one huh :) yeah will add. > Also are you sure about the value? I vaguely recall that the FIFO was > 32-deep, you are confusing bytes and words here? I dont think this is related to FIFO depth, this is buffer to hold values. Will check though.. -- ~Vinod