From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbdLCRJX (ORCPT ); Sun, 3 Dec 2017 12:09:23 -0500 Received: from mga04.intel.com ([192.55.52.120]:50437 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbdLCRJU (ORCPT ); Sun, 3 Dec 2017 12:09:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,354,1508828400"; d="scan'208";a="9047980" Date: Sun, 3 Dec 2017 22:42:56 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: Greg Kroah-Hartman , LKML , ALSA , Mark , Takashi , patches.audio@intel.com, alan@linux.intel.com, Charles Keepax , Sagar Dharia , srinivas.kandagatla@linaro.org, plai@codeaurora.org, Sudheer Papothi Subject: Re: [alsa-devel] [PATCH v4 00/15] soundwire: Add a new SoundWire subsystem Message-ID: <20171203171255.GR32417@localhost> References: <1512122177-2889-1-git-send-email-vinod.koul@intel.com> <404dd97d-767d-1f93-949b-487dcca96256@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <404dd97d-767d-1f93-949b-487dcca96256@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2017 at 06:24:10PM -0600, Pierre-Louis Bossart wrote: > On 12/1/17 3:56 AM, Vinod Koul wrote: > >This patch series adds a new SoundWire subsystem which implements a > >new MIPI bus protocol 'SoundWire'. > > Sorry for the late feedback Vinod and team. > > Overall the code looks very good to me and aligned with the MIPI specs, > there are only a couple of points that were added (or some code not removed) > during the code cleanups, e.g. > - device12..14 should not be used > - device_property handling (master/controller confusion?) > - error cases on transfers > - spec race condition on interrupt clear (not bad but to be discussed > further) > - some comments and code nit-picks > > This is starting to get into second-order reviews really, which shows this > is becoming quite mature. And for the record this work isn't just scratching > the surface, it helped identify a couple of documentation issues in the MIPI > specs which will lead to clarifications in future revisions. Thanks for the good word, most the stuff you pointed needs a very detailed review, so many thaks for spending time on this one. > Looking forward to a v5 ;-) Yeah should be there in next few days.. -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v4 00/15] soundwire: Add a new SoundWire subsystem Date: Sun, 3 Dec 2017 22:42:56 +0530 Message-ID: <20171203171255.GR32417@localhost> References: <1512122177-2889-1-git-send-email-vinod.koul@intel.com> <404dd97d-767d-1f93-949b-487dcca96256@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by alsa0.perex.cz (Postfix) with ESMTP id 7CEAF266B0F for ; Sun, 3 Dec 2017 18:09:21 +0100 (CET) Content-Disposition: inline In-Reply-To: <404dd97d-767d-1f93-949b-487dcca96256@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: ALSA , Charles Keepax , Sudheer Papothi , Takashi , Greg Kroah-Hartman , plai@codeaurora.org, LKML , patches.audio@intel.com, Mark , srinivas.kandagatla@linaro.org, Sagar Dharia , alan@linux.intel.com List-Id: alsa-devel@alsa-project.org On Fri, Dec 01, 2017 at 06:24:10PM -0600, Pierre-Louis Bossart wrote: > On 12/1/17 3:56 AM, Vinod Koul wrote: > >This patch series adds a new SoundWire subsystem which implements a > >new MIPI bus protocol 'SoundWire'. > > Sorry for the late feedback Vinod and team. > > Overall the code looks very good to me and aligned with the MIPI specs, > there are only a couple of points that were added (or some code not removed) > during the code cleanups, e.g. > - device12..14 should not be used > - device_property handling (master/controller confusion?) > - error cases on transfers > - spec race condition on interrupt clear (not bad but to be discussed > further) > - some comments and code nit-picks > > This is starting to get into second-order reviews really, which shows this > is becoming quite mature. And for the record this work isn't just scratching > the surface, it helped identify a couple of documentation issues in the MIPI > specs which will lead to clarifications in future revisions. Thanks for the good word, most the stuff you pointed needs a very detailed review, so many thaks for spending time on this one. > Looking forward to a v5 ;-) Yeah should be there in next few days.. -- ~Vinod