From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752025AbdLDXH4 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Dec 2017 18:07:56 -0500
Received: from merlin.infradead.org ([205.233.59.134]:55650 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751436AbdLDXHx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Dec 2017 18:07:53 -0500
Date: Tue, 5 Dec 2017 00:06:59 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Hansen <dave.hansen@intel.com>, Borislav Petkov <bpetkov@suse.de>,
        Greg KH <gregkh@linuxfoundation.org>, Kees Cook <keescook@google.com>,
        Hugh Dickins <hughd@google.com>, Brian Gerst <brgerst@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Rik van Riel <riel@redhat.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        David Laight <David.Laight@aculab.com>,
        Eduardo Valentin <eduval@amazon.com>, aliguori@amazon.com,
        Will Deacon <will.deacon@arm.com>,
        Daniel Gruss <daniel.gruss@iaik.tugraz.at>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>, michael.schwarz@iaik.tugraz.at,
        Borislav Petkov <bp@alien8.de>, moritz.lipp@iaik.tugraz.at,
        richard.fellner@student.tugraz.at, Andrew Banman <abanman@hpe.com>,
        mike.travis@hpe.com
Subject: Re: [patch 51/60] x86/mm: Allow flushing for future ASID switches
Message-ID: <20171204230659.GG20227@worktop.programming.kicks-ass.net>
References: <20171204140706.296109558@linutronix.de>
 <20171204150609.002009374@linutronix.de>
 <CALCETrX+DaXTTTQs_b_9nq2BpkCxrTv5FzLgyMd23wxczXn=GQ@mail.gmail.com>
 <20171204224757.GC20227@worktop.programming.kicks-ass.net>
 <CALCETrUHkwHLb7pwcsfUfaEfdZtSTVxd0=e2AXVmQ0zBm7srUA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrUHkwHLb7pwcsfUfaEfdZtSTVxd0=e2AXVmQ0zBm7srUA@mail.gmail.com>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 04, 2017 at 02:54:46PM -0800, Andy Lutomirski wrote:
> On Mon, Dec 4, 2017 at 2:47 PM, Peter Zijlstra <peterz@infradead.org> wrote:

> > As is __flush_tlb_single() does user and __flush_tlb_one() does
> > user+kernel.
> 
> Yep.  A one-liner above the function to that effect would make it
> *way* clearer what's going on.

Bah, since my notes are upstairs I actually got that wrong,
do_kernel_range_flush() also uses __flush_tlb_single(), but then it
finishes with invalidate_pcid_other(), so effectively it shoots down
world.

So we should probably switch do_kernel_range_flush() to
__flush_tlb_one() and tlb_uv.c (pending SGI approval) to
__flush_tlb_single().

I'll dig through my notes in the morning and do a patch with comments.