From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH 6/7] devtools/test-build: add MRVL NET PMD to
 test-build
Date: Tue, 5 Dec 2017 09:38:10 +0100
Message-ID: <20171205083810.GA23865@tdu>
References: <1512048743-23749-1-git-send-email-tdu@semihalf.com>
 <1512141592-16695-1-git-send-email-tdu@semihalf.com>
 <1512141592-16695-7-git-send-email-tdu@semihalf.com>
 <d87cabec-bec6-09df-f5ef-03cdd6c4ed4e@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org, mw@semihalf.com,
 jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com,
 jianbo.liu@arm.com
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com
 [209.85.215.67]) by dpdk.org (Postfix) with ESMTP id D3DA3397D
 for <dev@dpdk.org>; Tue,  5 Dec 2017 09:38:12 +0100 (CET)
Received: by mail-lf0-f67.google.com with SMTP id t197so22269463lfe.7
 for <dev@dpdk.org>; Tue, 05 Dec 2017 00:38:12 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <d87cabec-bec6-09df-f5ef-03cdd6c4ed4e@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Dec 04, 2017 at 04:48:51PM -0800, Ferruh Yigit wrote:
> On 12/1/2017 7:19 AM, Tomasz Duszynski wrote:
> > Add MRVL NET PMD to test build tool.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> >  devtools/test-build.sh | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> > index 092d3a7..78609c9 100755
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -197,6 +197,7 @@ config () # <directory> <target> <options>
> >  		sed -ri           's,(SCHED_.*=3D)n,\1y,' $1/.config
> >  		test -z "$LIBMUSDK_PATH" || \
> >  		sed -ri    's,(PMD_MRVL_CRYPTO=3D)n,\1y,' $1/.config
> > +		sed -ri           's,(MRVL_PMD=3D)n,\1y,' $1/.config
>
> Won't MRVL_PMD also require LIBMUSDK_PATH?
> For this case check doesn't cover it and will be enabled always.
>

Good catch. Will be fixed in v3.

> >  		build_config_hook $1 $2 $3
> >
> >  		# Explicit enabler/disabler (uppercase)
> >
>

--
- Tomasz Duszy=C5=84ski