From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH v6 6/8] KVM: arm/arm64: Support VGIC dist pend/active changes for mapped IRQs Date: Tue, 5 Dec 2017 13:43:54 +0100 Message-ID: <20171205124354.ghtqq3fxy7fsaudy@kamzik.brq.redhat.com> References: <20171204200506.3224-1-cdall@kernel.org> <20171204200506.3224-7-cdall@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Marc Zyngier , Andre Przywara , Eric Auger , Christoffer Dall To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36706 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbdLEMoB (ORCPT ); Tue, 5 Dec 2017 07:44:01 -0500 Content-Disposition: inline In-Reply-To: <20171204200506.3224-7-cdall@kernel.org> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Dec 04, 2017 at 09:05:04PM +0100, Christoffer Dall wrote: > +/* Must be called with irq->irq_lock held */ > +static void vgic_hw_irq_change_active(struct kvm_vcpu *vcpu, struct vgic_irq *irq, > + bool active, bool is_uaccess) > +{ > + if (!is_uaccess) > + irq->active = active;; > + > + if (!is_uaccess) > + vgic_irq_set_phys_active(irq, active); > +} > + Missed one. drew From mboxrd@z Thu Jan 1 00:00:00 1970 From: drjones@redhat.com (Andrew Jones) Date: Tue, 5 Dec 2017 13:43:54 +0100 Subject: [PATCH v6 6/8] KVM: arm/arm64: Support VGIC dist pend/active changes for mapped IRQs In-Reply-To: <20171204200506.3224-7-cdall@kernel.org> References: <20171204200506.3224-1-cdall@kernel.org> <20171204200506.3224-7-cdall@kernel.org> Message-ID: <20171205124354.ghtqq3fxy7fsaudy@kamzik.brq.redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Dec 04, 2017 at 09:05:04PM +0100, Christoffer Dall wrote: > +/* Must be called with irq->irq_lock held */ > +static void vgic_hw_irq_change_active(struct kvm_vcpu *vcpu, struct vgic_irq *irq, > + bool active, bool is_uaccess) > +{ > + if (!is_uaccess) > + irq->active = active;; > + > + if (!is_uaccess) > + vgic_irq_set_phys_active(irq, active); > +} > + Missed one. drew