From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 05 Dec 2017 14:38:43 +0000 Subject: [PATCH] xen/pvcalls: check for xenbus_read() errors Message-Id: <20171205143843.hj7b4ayvbgf5ftzl@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Boris Ostrovsky , Stefano Stabellini Cc: Juergen Gross , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org Smatch complains that "len" is uninitialized if xenbus_read() fails so let's add some error handling. Signed-off-by: Dan Carpenter diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index 40caa92bff33..afa3f1b5d807 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pvcalls-front.c @@ -1128,6 +1128,8 @@ static int pvcalls_front_probe(struct xenbus_device *dev, } versions = xenbus_read(XBT_NIL, dev->otherend, "versions", &len); + if (IS_ERR(versions)) + return PTR_ERR(versions); if (!len) return -EINVAL; if (strcmp(versions, "1")) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] xen/pvcalls: check for xenbus_read() errors Date: Tue, 5 Dec 2017 17:38:43 +0300 Message-ID: <20171205143843.hj7b4ayvbgf5ftzl@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMEN6-0004t5-OQ for xen-devel@lists.xenproject.org; Tue, 05 Dec 2017 14:38:56 +0000 Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Boris Ostrovsky , Stefano Stabellini Cc: Juergen Gross , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org List-Id: xen-devel@lists.xenproject.org U21hdGNoIGNvbXBsYWlucyB0aGF0ICJsZW4iIGlzIHVuaW5pdGlhbGl6ZWQgaWYgeGVuYnVzX3Jl YWQoKSBmYWlscyBzbwpsZXQncyBhZGQgc29tZSBlcnJvciBoYW5kbGluZy4KClNpZ25lZC1vZmYt Ynk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KCmRpZmYgLS1naXQg YS9kcml2ZXJzL3hlbi9wdmNhbGxzLWZyb250LmMgYi9kcml2ZXJzL3hlbi9wdmNhbGxzLWZyb250 LmMKaW5kZXggNDBjYWE5MmJmZjMzLi5hZmEzZjFiNWQ4MDcgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv eGVuL3B2Y2FsbHMtZnJvbnQuYworKysgYi9kcml2ZXJzL3hlbi9wdmNhbGxzLWZyb250LmMKQEAg LTExMjgsNiArMTEyOCw4IEBAIHN0YXRpYyBpbnQgcHZjYWxsc19mcm9udF9wcm9iZShzdHJ1Y3Qg eGVuYnVzX2RldmljZSAqZGV2LAogCX0KIAogCXZlcnNpb25zID0geGVuYnVzX3JlYWQoWEJUX05J TCwgZGV2LT5vdGhlcmVuZCwgInZlcnNpb25zIiwgJmxlbik7CisJaWYgKElTX0VSUih2ZXJzaW9u cykpCisJCXJldHVybiBQVFJfRVJSKHZlcnNpb25zKTsKIAlpZiAoIWxlbikKIAkJcmV0dXJuIC1F SU5WQUw7CiAJaWYgKHN0cmNtcCh2ZXJzaW9ucywgIjEiKSkgewoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==