From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jitendra Sharma <shajit@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Arun Kumar Neelakantam <aneela@codeaurora.org>,
Chris Lew <clew@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder
Date: Tue, 5 Dec 2017 09:33:16 -0800 [thread overview]
Message-ID: <20171205173316.GP28761@minitux> (raw)
In-Reply-To: <6c6be375-6895-ecaf-9844-40774f6bdd5c@codeaurora.org>
On Fri 01 Dec 01:10 PST 2017, Jitendra Sharma wrote:
> Hi Bjorn,
>
Hi Jitendra,
> On 11/30/2017 6:46 AM, Bjorn Andersson wrote:
> > +static int qmi_calc_min_msg_len(struct qmi_elem_info *ei_array,
> > + int level)
> > +{
> > + int min_msg_len = 0;
> min_msg_len should be u32 as it would not be negative
IMHO all these sizes should be size_t and there are a few places where
we should add "const" specifier to pointers. But I refrained from
"fixing" these up in an effort to keep things as close to the downstream
implementation as possible.
If Andy agrees I'm hoping that we can take this version and then follow
up with a separate patch, making the review more explicit and make it
easier to track down any potential regressions from such a change.
Thank you for the review!
Regards,
Bjorn
next prev parent reply other threads:[~2017-12-05 17:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 1:16 [PATCH v4 0/5] In-kernel QMI helpers and sysmon Bjorn Andersson
2017-11-30 1:16 ` [PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder Bjorn Andersson
2017-11-30 17:17 ` Chris Lew
2017-12-01 9:10 ` Jitendra Sharma
2017-12-05 17:33 ` Bjorn Andersson [this message]
2017-11-30 1:16 ` [PATCH v4 2/5] soc: qcom: Introduce QMI helpers Bjorn Andersson
2017-11-30 8:18 ` Philippe Ombredanne
2017-12-01 5:35 ` Bjorn Andersson
2017-12-01 7:48 ` Philippe Ombredanne
2017-11-30 17:33 ` Chris Lew
2017-11-30 1:16 ` [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove Bjorn Andersson
2017-11-30 17:35 ` Chris Lew
2017-12-01 14:50 ` Arnaud Pouliquen
2017-12-01 14:50 ` Arnaud Pouliquen
2017-12-05 6:46 ` Bjorn Andersson
2017-12-05 10:54 ` Arnaud Pouliquen
2017-12-05 10:54 ` Arnaud Pouliquen
2017-12-05 17:17 ` Bjorn Andersson
2017-12-06 8:55 ` Arnaud Pouliquen
2017-12-06 8:55 ` Arnaud Pouliquen
2017-12-06 21:53 ` Bjorn Andersson
2017-12-07 12:14 ` Arnaud Pouliquen
2017-12-07 12:14 ` Arnaud Pouliquen
2017-11-30 1:16 ` [PATCH v4 4/5] remoteproc: qcom: Introduce sysmon Bjorn Andersson
2017-12-01 1:52 ` Chris Lew
2017-12-01 5:31 ` Bjorn Andersson
2017-12-01 5:31 ` Bjorn Andersson
2017-11-30 1:16 ` [PATCH v4 5/5] samples: Introduce Qualcomm QMI sample client Bjorn Andersson
2017-11-30 17:36 ` Chris Lew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205173316.GP28761@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=shajit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.