From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support.
Date: Tue, 5 Dec 2017 20:40:50 +0200 [thread overview]
Message-ID: <20171205184050.7oifghyqfbrhehdr@tarshish.tkos.co.il> (raw)
In-Reply-To: <20171205131005.31537-1-aduskett@gmail.com>
Hi Adam,
On Tue, Dec 05, 2017 at 08:10:05AM -0500, Adam Duskett wrote:
> The streaming protocol works without libcurl via RTP, but if a user wishes to
> stream via RTSP, libcurl must be built first.
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
> package/janus-gateway/Config.in | 8 +++++++-
> package/janus-gateway/janus-gateway.mk | 4 ++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
> index 5bd4e9586b..ed68e270d6 100644
> --- a/package/janus-gateway/Config.in
> +++ b/package/janus-gateway/Config.in
> @@ -38,6 +38,12 @@ config BR2_PACKAGE_JANUS_STREAMING
> # SO_REUSEPORT
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>
> +if BR2_PACKAGE_JANUS_STREAMING
> +config BR2_PACKAGE_JANUS_STREAMING_RTSP
> + bool "RTSP streaming"
> + select BR2_PACKAGE_LIBCURL
> +endif
> +
> comment "streaming plugin needs a toolchain w/ headers >= 3.9"
> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>
> @@ -90,7 +96,7 @@ config BR2_PACKAGE_JANUS_WEBSOCKETS
> depends on BR2_USE_MMU
> select BR2_PACKAGE_LIBWEBSOCKETS
>
> -endif
> +endif #BR2_PACKAGE_JANUS_GATEWAY
>
> comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
> depends on BR2_USE_MMU
> diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
> index bf3e590ac5..be31c465f8 100644
> --- a/package/janus-gateway/janus-gateway.mk
> +++ b/package/janus-gateway/janus-gateway.mk
> @@ -58,6 +58,10 @@ else
> JANUS_GATEWAY_CONF_OPTS += --disable-plugin-streaming
> endif
>
> +ifeq ($(BR2_PACKAGE_JANUS_STREAMING_RTSP),y)
> +JANUS_GATEWAY_DEPENDENCIES += libcurl
> +endif
Is there a way to disable RTSP? If not, RTSP will be enabled whenever libcurl
happens to build before janus-gateway, right? So maybe having libcurl as a
usual optional dependency would be better.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2017-12-05 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 13:10 [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support Adam Duskett
2017-12-05 18:40 ` Baruch Siach [this message]
2017-12-12 11:30 ` Adam Duskett
2017-12-12 18:58 ` Baruch Siach
2017-12-13 13:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205184050.7oifghyqfbrhehdr@tarshish.tkos.co.il \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.